Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-17 Thread Paul Hoadley
On 16 Apr 2016, at 2:25 pm, Paul Hoadley wrote: > 1. With the new method signature for arrayMinusArray(), WOUnit’s > MockEditingContext can’t even find that method: > > java.lang.NoSuchMethodError: > er.extensions.foundation.ERXArrayUtilities.arrayMinusArray(Lcom/webobjects

Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-16 Thread Paul Hoadley
Hi Johann, On 16 Apr 2016, at 4:15 pm, Johann Werner wrote: >> I think I have narrowed it down: the behaviour of the old and new methods >> are different with respect to duplicate objects in the supplied array. >> Specifically, if the object to be removed is present more than once in the >> a

Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-15 Thread Johann Werner
Hi Paul, > Am 16.04.2016 um 00:55 schrieb Paul Hoadley : > > Hi Johann, > > On 15 Apr 2016, at 11:53 pm, Johann Werner wrote: > >> do you have an example where ERXEOControlUtilities.validateUniquenessOf() >> does not work because of ERXArrayUtilities.arrayMinusObject()? What is the >> exact

Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-15 Thread Paul Hoadley
On 16 Apr 2016, at 8:57 am, Paul Hoadley wrote: >> And while we’re here: >> 1. With the new method signature for arrayMinusArray(), WOUnit’s MockEditingContext can’t even find that method: java.lang.NoSuchMethodError: er.extensions.foundation.ERXArrayUtilities.arrayMi

Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-15 Thread Paul Hoadley
On 16 Apr 2016, at 8:42 am, Chuck Hill wrote: > Good catch! It should use removeAll() not remove(). Even using removeObject() (which is what the original implementation used) reverts the behaviour. Johann, would you have any objection to me making this change to restore the old behaviour of a

Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-15 Thread Chuck Hill
bjects Development mailto:webobjects-dev@lists.apple.com>> Subject: Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject() Hi Johann, On 15 Apr 2016, at 11:53 pm, Johann Werner mailto:j...@oyosys.de>> wrote: do you have an example where ERXEOControlUtilities.va

Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-15 Thread Paul Hoadley
Hi Johann, On 15 Apr 2016, at 11:53 pm, Johann Werner wrote: > do you have an example where ERXEOControlUtilities.validateUniquenessOf() > does not work because of ERXArrayUtilities.arrayMinusObject()? What is the > exact error? This is in the middle of a WOUnit test, so the error is that va

Re: Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-15 Thread Johann Werner
Hi Paul, do you have an example where ERXEOControlUtilities.validateUniquenessOf() does not work because of ERXArrayUtilities.arrayMinusObject()? What is the exact error? I did a quick test in my code and could not see wrong outcome. Looking at the code change before that commit: public stati

Issues with ERXArrayUtilities.arrayMinusArray() and arrayMinusObject()

2016-04-15 Thread Paul Hoadley
Hi Johann, In 1d56e6d6, you changed the API for these methods—I assume "use interfaces as params where possible” from the log comment was your rationale here, and that seems pretty reasonable. Here are a couple of caveats for my comments to follow: * We agreed that Wonder 7 need not maintain ba