[webstack-discuss] CR 6635728 - Code review request (RESEND)

2008-03-06 Thread Prashant Srinivasan
Siva, looks fine. -ps Sivakumar Shanmugasundaram wrote: > Prashant, > > I have fixed the shebang to /usr/ruby/1.8/bin/ruby now. Please review > again. Thanks. > > Regards > Siva > > > Prashant Srinivasan wrote: >> Siva, >> lets use /usr/ruby/1.8/bin/ruby in the shebang line. Using >> /usr/bin

[webstack-discuss] Reminder: Code Review Request for CR:6634053

2008-03-06 Thread Sunanda Menon
Thanks Rahul , Will make these changes . rahul wrote: > | > As part of the CR :6634053 Integrate MySQL 64-bit release ,I would > | > like the changes to be reviewed at > | > http://cr.opensolaris.org/~sunandam/6634053/ > > http://cr.opensolaris.org/~sunandam/6634053/usr/src/Targetdirs.udiff.html

[webstack-discuss] Reminder: Code Review Request for CR:6634053

2008-03-06 Thread rahul
| > As part of the CR :6634053 Integrate MySQL 64-bit release ,I would | > like the changes to be reviewed at | > http://cr.opensolaris.org/~sunandam/6634053/ http://cr.opensolaris.org/~sunandam/6634053/usr/src/Targetdirs.udiff.html SYM.ROOT.BIN64= \ /usr/lib/64 \ /usr/postg

[webstack-discuss] lighttpd and sqlite 3

2008-03-06 Thread Amanda Waite
To enable more modules in the lighttpd integration I would need sqlite3. I know it's being integrated but is there a way to build against it in sfwnv today? Otherwise I'll slate it for the next update to the Lighttpd integration. Apologies if this is dumb question. Thanks Amanda -- Amanda W

[webstack-discuss] Lighttpd Arc Case

2008-03-06 Thread Amanda Waite
Jyri Virkki wrote: > > You could do it in the future. Or you could definte the mechanism > (location and inclusion rules) now and only later make use of it. > Earlier is nicer than later, but your choice. > I've added details about conf.d and a couple of config files that we can include in the

[webstack-discuss] Reminder: Code Review Request for CR:6634053

2008-03-06 Thread Sunanda Menon
Sunanda Menon wrote: > Hi , > > As part of the CR :6634053 Integrate MySQL 64-bit release ,I would > like the changes to be reviewed at > http://cr.opensolaris.org/~sunandam/6634053/ > Please let me know your comments . > > Thanks > -- Sunanda Menon Database Technology Group BLR03, x87098/91-80

[webstack-discuss] Code Review Request for CR:6634053

2008-03-06 Thread Jyri Virkki
Sunanda Menon wrote: > > As part of the CR :6634053 Integrate MySQL 64-bit release ,I would like > the changes to be reviewed at > http://cr.opensolaris.org/~sunandam/6634053/ > Please let me know your comments . usr/src/Targetdirs - These lists are mostly kept in alphabetical order, so adjust

[webstack-discuss] Code Review Request for 6640026 (RESEND)

2008-03-06 Thread Sunanda Menon
Indentation corrected . Can you verify again please at the same link . Thanks Sunanda Jyri Virkki wrote: > Sunanda Menon wrote: > >> The changes have been incorporated .Could you please review it again at >> the same link http://cr.opensolaris.org/~sunandam/6640026 >> > > Detail, but why

[webstack-discuss] CR 6635728 - Code review request (RESEND)

2008-03-06 Thread Sivakumar Shanmugasundaram
Team! Resending it again, as I havent got any reviews, as possibly it was sent as a reply to an existing thread. Please review the webrev (same URL = http://cr.opensolaris.org/~ss39446/ruby-cr6635728) which contain fixes for both the problems mentioned in this CR (1. SUNWruby18u package dependen

[webstack-discuss] DRAFT ARC case for mod_python and mod_ruby

2008-03-06 Thread rahul
Hi, The *DRAFT* ARC case for mod_ruby and mod_python is below. Please do review. Additional Apache2 Modules mod_python and mod_ruby 11 March 2008 1.Summary and motivation 1.1.Introduction This project delivers Apache modules mod_python and mod_ruby to the Apache2 (PSA

[webstack-discuss] functional testing of PostGres in OpenSolaris

2008-03-06 Thread jean jayet
CVR, in response to your demand to functional test the PostGres integrated within OpenSolaris (nevada, indiana releases) as any other component the WebStack Eng team is integrating i've been in touch with the DBTG team responsible for integrating and testing this component for what i've under

[webstack-discuss] lighttpd and sqlite 3

2008-03-06 Thread Henry Jen
> > (IIRC, but I could misremember, sqlite3 isn't going into sfw, so it > means you also have to wait some more, so it can propagate to build > machine requirements. So yes, sounds like waiting for later is best.) nico (Nicolas Williams) is taking sqlite3 to sfw[1]. [1] http://opensolaris.org/

[webstack-discuss] Code Review Request for 6640026 (RESEND)

2008-03-06 Thread Jyri Virkki
Sunanda Menon wrote: > > Indentation corrected . > Can you verify again please at the same link . Looks ok to me now. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems

[webstack-discuss] lighttpd and sqlite 3

2008-03-06 Thread Jyri Virkki
Amanda Waite wrote: > > To enable more modules in the lighttpd integration I would need sqlite3. > I know it's being integrated but is there a way to build against it in > sfwnv today? Otherwise I'll slate it for the next update to the Lighttpd > integration. Right, you'll need to wait until it

[webstack-discuss] Webstack functional tests packages available

2008-03-06 Thread Eric
All, New functional tests packages are available on /net/sisyphe.france/export/pkg/solaris/webstack Tests have been adapted to take into account Apache 32/64 bits and Wroker/prefork modes. document can be found on our wiki page : https://twiki.france/bin/view/WebStackQA/TestAutomation In case

[webstack-discuss] Enhancing Ruby with DTrace probes [PSARC/2008/174 Self Review]

2008-03-06 Thread Darren J Moffat
Garrett D'Amore wrote: > This looks much better. Thanks. Agreed. I'm happy with this case now. -- Darren J Moffat

[webstack-discuss] Enhancing Ruby with DTrace probes [PSARC/2008/174 Self Review]

2008-03-06 Thread Darren J Moffat
Jyri Virkki wrote: > Darren J Moffat wrote: >> Based on your description that there is no architectural issue with >> providing the probes on SPARC just a build environment issue. >> >> Given what you described the way I would recommend that this case is >> changed to provide the functionality on

[webstack-discuss] Code Review Request for 6640026 (RESEND)

2008-03-06 Thread Sunanda Menon
Hi Jyri , The changes have been incorporated .Could you please review it again at the same link http://cr.opensolaris.org/~sunandam/6640026 Thanks Sunanda Jyri Virkki wrote: > Sunanda Menon wrote: > >> Hello Jyri , >> >> The code changes have been done with _install P option .Please review

[webstack-discuss] CR 6635728 - Code review request (RESEND)

2008-03-06 Thread Prashant Srinivasan
Siva, lets use /usr/ruby/1.8/bin/ruby in the shebang line. Using /usr/bin/env ruby is a good idea for user programs that don't need to tie in to a specific version. But, since the packages that we're delivering actually depend on ruby 1.8, it's good to make the shebang as specific as possible

[webstack-discuss] Code Review Request for 6640026 (RESEND)

2008-03-06 Thread Jyri Virkki
Sunanda Menon wrote: > > The changes have been incorporated .Could you please review it again at > the same link http://cr.opensolaris.org/~sunandam/6640026 Detail, but why the inconsistent indentation in this section? + echo "file is $file" +if [ $(basename $dirs) = 'lib' ]; then +

[webstack-discuss] Lighttpd Arc Case

2008-03-06 Thread Jyri Virkki
Amanda waite wrote: > > Yes it is possible to deliver additional config files in this way. I'd > need to better understand how the mechanism works in Apache2 and if it > could be applied to Lighttpd. Is this something we can look at for > future packages then? You could do it in the future. Or