[webstack-discuss] [sfwnv-discuss] Reminder: CR 6665970 (memcached 1.2.5) - Code Review Request

2008-03-19 Thread Victor Kirkebo
Norm Jacobs wrote: > Victor Kirkebo wrote: >> Please see my comments inline. >> Norm Jacobs wrote: >> >>> As your RTI advocate, I normally do a code review anyway, but you >>> should not rely on that for your code review. If you use me as a >>> code reviewer, you will need to use another advoc

[webstack-discuss] Delivering configuration files for Apache 2.2 modules

2008-03-19 Thread rahul
Sorry, Withdrawing the diff for changes. [rahul:] | Hi, | The default configuration files for mod_security2, mod_jk, | mod_fcgid, mod_dtrace are being integrated with this CR. (6675431) | The diffs are availabe here. | http://cr.opensolaris.org/~vrthra/6675431.modules/

[webstack-discuss] Delivering configuration files for Apache 2.2 modules

2008-03-19 Thread rahul
Hi, The default configuration files for mod_security2, mod_jk, mod_fcgid, mod_dtrace are being integrated with this CR. (6675431) The diffs are availabe here. http://cr.opensolaris.org/~vrthra/6675431.modules/ Please do review. rahul -- 1. e4 _

[webstack-discuss] [sfwnv-discuss] Reminder: CR 6665970 (memcached 1.2.5) - Code Review Request

2008-03-19 Thread Trond Norbye
On Mar 19, 2008, at 2:33 PM, Victor Kirkebo wrote: >> SUNWmemcached-java/depend: same comment, though shouldn't you have a >> dependency on one of the java packages (SUNWj6rt or something)? >> > SUNWj5rt added. I am not sure why we need to have a dependency upon any Java package. You will of co

[webstack-discuss] DRAFT ARC case for mod_python and mod_ruby

2008-03-19 Thread rahul
Updated Arc DRAFT attached. | | Will these modules be loaded by default ? Do you plan to provide the | | corresponding '.conf' files ? | | oops, my mistake :). the conf updates for other modules should get done | before this gets integrated. | I will add the conf file to the arc case and update.

[webstack-discuss] DRAFT ARC case for Drupal 6.x for review

2008-03-19 Thread Seema
Sriram Natarajan wrote: >Well, in a production environment, customer might choose to keep their >document directories in a more segregated fashion depending on their >virtual server setup. In this case, I am not sure, if you would very >much want to associate your installation to a particular

[webstack-discuss] [sfwnv-discuss] Reminder: CR 6665970 (memcached 1.2.5) - Code Review Request

2008-03-19 Thread Victor Kirkebo
Please see my comments inline. Norm Jacobs wrote: > > As your RTI advocate, I normally do a code review anyway, but you > should not rely on that for your code review. If you use me as a code > reviewer, you will need to use another advocate for your RTI. At any > rate, here are my comments fr

[webstack-discuss] [sfwnv-discuss] Reminder: CR 6665970 (memcached 1.2.5) - Code Review Request

2008-03-19 Thread Victor Kirkebo
Please see my comments inline. Danek Duvall wrote: > On Tue, Mar 11, 2008 at 01:15:03PM +0100, Victor Kirkebo wrote: > > >> http://cr.opensolaris.org/~vk136562/memcached-1.2.5/ >> > > Mike recently putback fixes for 6657798. You need to follow the direction > he set there. In particular,

[webstack-discuss] Delivering configuration files for Apache 2.2 modules

2008-03-19 Thread Sriram Natarajan
I see couple of issues in delivering fcgid.conf and security.conf . Since these are now delivered as separate configuration files and will be read only after reading the entire httpd.conf, customers who want to customize the features of this module will now have no reliable way of configuring

[webstack-discuss] Need to start a discussion on mysql_config

2008-03-19 Thread Sunanda Menon
Hi Martin, So what's the suggestion ?Since this feature will be available in next MySQL release ,do we continue to fix this problem in 5.0.4 or can this wait . Please give your inputs . Thanks Sunanda Martin MC Brown wrote: > Hi everybody, > > I discussed this issue with the build team this

[webstack-discuss] [sfwnv-discuss] Reminder: CR 6665970 (memcached 1.2.5) - Code Review Request

2008-03-19 Thread Norm Jacobs
Victor Kirkebo wrote: > Please see my comments inline. > Norm Jacobs wrote: > >> As your RTI advocate, I normally do a code review anyway, but you >> should not rely on that for your code review. If you use me as a code >> reviewer, you will need to use another advocate for your RTI. At any

[webstack-discuss] Need to start a discussion on mysql_config

2008-03-19 Thread Martin MC Brown
Hi, > So what's the suggestion ?Since this feature will be available in > next MySQL release ,do we continue to fix this problem in 5.0.4 or > can this wait . Well, I wouldn't want to guarantee that a fix will go in that quickly. For the version we in OpenSolaris, I think it would be easie

[webstack-discuss] [Fwd: Re: [dtrace-discuss] DTrace for MySQL?]

2008-03-19 Thread Martin MC Brown
Hi Jenny, > The DTrace probes in MySQL 6.0.4 works fine, and it provide very > useful online information for query execution time; in addition, it > provide execution time of queries being replicated to help > understand the replication load and manage the replication lag. Oh yeah, it's co

[webstack-discuss] DRAFT ARC case for Drupal 6.x for review

2008-03-19 Thread Eric Reid
Great questions, Peter... responses inline... Peter Tribble wrote: > On Tue, Mar 18, 2008 at 3:48 PM, Eric Reid wrote: > >> Please find attached for review: >> OnePager >> ManPage appendix >> FileList appendix >> >> Let the games begin! :) >> > ... > >> 3. Business Summary >>