[webstack-discuss] varnish (experimental)

2008-04-08 Thread Jyri Virkki
I have added a varnish package (SUNWvarnish) to the experimental web stack repository in case anyone wants to experiment with it. If you have not tried the repository yet, see http://www.opensolaris.org/jive/thread.jspa?threadID=56434&tstart=0 and http://blogs.sun.com/jyrivirkki/entry/experimental

[webstack-discuss] Need Code Review for Ruby Native Gem Support

2008-04-08 Thread Jyri Virkki
Gopalakrishnan Sankaran wrote: > > Hi Siva, Jyri, > > I have made the changes reqd (including the appropriate #ident). I ran > wx pbchk which returned no errors. > > Kindly review the code changes. > > http://cr.opensolaris.org/~gs193864/cr6644643/ Not sure if you saw my comment from Apr.4 but

[webstack-discuss] Need Code Review for Ruby Native Gem Support

2008-04-08 Thread Gopalakrishnan Sankaran
Hi Siva, Jyri, I have made the changes reqd (including the appropriate #ident). I ran wx pbchk which returned no errors. Kindly review the code changes. http://cr.opensolaris.org/~gs193864/cr6644643/ Thanks, Gopal. Sivakumar Shanmugasundaram wrote: > Gopal, > > Looks good to me. I assume you

[webstack-discuss] Need Code Review for Ruby Native Gem Support

2008-04-08 Thread Sivakumar Shanmugasundaram
Gopal, Looks good to me. I assume you have done 'wx pbchk' on your wokspace and do not get any errors from this command. Oh, I do not see Jyri's comments addressed. Please fix them. Add the appropriate '#ident' and do 'wx redelget' Siva Gopalakrishnan Sankaran wrote: > Hi Siva, > > Have made

[webstack-discuss] Reminder: Code Review request for 6664712

2008-04-08 Thread Martin MC Brown
Hi Sunanda, > Kindly review this bug and let me know your comments by April 8th > EOD . > > Thanks Sunanda >> >>> Please review the code changes for CR 6664712 : mysql_config >>> provides >>> incorrect link library configuration. >>> at http://cr.opensolaris.org/~sunandam/6664712/ >>> >>> Than

[webstack-discuss] Request to review CR: 6658378

2008-04-08 Thread Sriram Natarajan
+1 - Sriram Basant Kukreja wrote: > Hi, >I have submitted the patch for the apache bug 42580. > https://issues.apache.org/bugzilla/show_bug.cgi?id=42580 >This patch has been commited in Apache trunk. This is a solaris specific > bug. This has been reviewed by apr developers. > https://iss

[webstack-discuss] Need Code Review for Ruby Native Gem Support

2008-04-08 Thread Gopalakrishnan Sankaran
Hi Siva, Have made the changes. Please review it again. http://cr.opensolaris.org/~gs193864/cr6644643/ Thanks, Gopal. Sivakumar Shanmugasundaram wrote: > Gopal, > > A couple of comments. > > Please change the Webrev comments to have the 'exact' bug synopsis > against all the files. > > You coul

[webstack-discuss] Need Code Review for Ruby Native Gem Support

2008-04-08 Thread Sivakumar Shanmugasundaram
Gopal, A couple of comments. Please change the Webrev comments to have the 'exact' bug synopsis against all the files. You could do a 'wx pbchk' to find errors postinstall-ruby: You could use another file name instead of just 'temp'. May be use rbconfig.$$ or similar. Other changes look goo

[webstack-discuss] Upstream bugs in Apache Webserver

2008-04-08 Thread Nick Kew
I'm sure people here know most or all of this. The part that's new to me is this webstack-discuss list as the right place to post. I'm now working for Sun on the webstack. I'm also a member of the Apache Software Foundation and the development teams for the webserver: both the HTTPD and APR proj

[webstack-discuss] Reminder: Code Review request for 6664712

2008-04-08 Thread Sunanda Menon
Hi , Kindly review this bug and let me know your comments by April 8th EOD . Thanks Sunanda > >> Please review the code changes for CR 6664712 : mysql_config provides >> incorrect link library configuration. >> at http://cr.opensolaris.org/~sunandam/6664712/ >> >> Thanks >> > >