Sunanda Menon wrote:
> Hi ,
>>
>> I would like to know if I can use /usr/sfw/bin/gmake instead of
>> /usr/ccs/bin/make for compilation of mysql5.1 for solaris.
>> I'm running into compilation issues for mysql5.1 using
>> /usr/ccs/bin/make .
You can use gmake to build components in the SFW consoli
Victor Kirkebo wrote:
> Please see my comments inline.
> Norm Jacobs wrote:
>
>> As your RTI advocate, I normally do a code review anyway, but you
>> should not rely on that for your code review. If you use me as a code
>> reviewer, you will need to use another adv
Danek Duvall wrote:
> On Tue, Mar 11, 2008 at 01:15:03PM +0100, Victor Kirkebo wrote:
>
>
>> http://cr.opensolaris.org/~vk136562/memcached-1.2.5/
> In memcached/install-sfw, you're copying the rbac (not smf, btw) files into
> place, even though you don't completely own them. Mike, is this okay
As your RTI advocate, I normally do a code review anyway, but you should
not rely on that for your code review. If you use me as a code
reviewer, you will need to use another advocate for your RTI. At any
rate, here are my comments from a quick pass through your webrev:
usr/src/lib/Makefile:
Because the diffs in the bug report are often useful when trying to
reconstruct or even backport an entire fix. Simply looking at the diffs
in the SCCS history for a file doesn't give you the whole picture. It
only gives you the change to that specific file.
-Norm
Jyri Virkki wrote:
