The updated WebRev's are posted at
http://cr.opensolaris.org/~sunandam/6693315/
Changes done are
1) env - introduced in the Makefile
2)Moved the Copyright lines to after the "CDDL HEADER END"
header for mysql.xml
3) METADATA file added.
Do you see any more changes needed?
Thanks Sunanda
O
*Very* quick skip through and it looks okay to me. Have you checked that
you have no pkg dependency changes with the 'dependency checker' script?
(may have asked that before).
Paul
Sunanda Menon wrote:
> The updated WebRev's are posted at
> http://cr.opensolaris.org/~sunandam/6693315/
>
> Cha
On 09/18/08 14:53, Paul Cunningham wrote:
> Sunanda,
>
> Here are a few more comments from quick skip through ..
>
> Paul
>
> Sunanda Menon wrote:
>> Updated WebRev's are posted at
>> http://cr.opensolaris.org/~sunandam/6693315/
>
> 1. usr/src/pkgdefs/SUNWmysql5test/prototype_com
>Do all these
Sunanda,
Here are a few more comments from quick skip through ..
Paul
Sunanda Menon wrote:
> Updated WebRev's are posted at http://cr.opensolaris.org/~sunandam/6693315/
1. usr/src/pkgdefs/SUNWmysql5test/prototype_com
Do all these files (f ) need the 'write' permission
bit set?
2. METAD
Updated WebRev's are posted at http://cr.opensolaris.org/~sunandam/6693315/
Changes done are
1) write permission removed from SUNWmysql5u package
2) pkginfo template version string removed from NAME field
3)One config patch called federated_cnf.patch created
Thanks Sunanda
On 09/10/08 13:47, Su
On 13/09 09.33, Sunanda Menon wrote:
> Bjorn ,
>
> Not sure why you say the patch fails ?This patch has been in use for a
> while now and I can see the patched file in the source .
OK, the way you invoke the patch is doesn't fail outright, as it did
when I tried it in a different context. Howev
Bjorn ,
Not sure why you say the patch fails ?This patch has been in use for a
while now and I can see the patched file in the source .
Please clarify ?
Thanks Sunanda
On 09/11/08 22:33, Bjorn Munch wrote:
> On 11/09 17.32, Bjorn Munch wrote:
>
>> On 09/09 14.40, Sunanda Menon wrote:
>>
On 11/09 17.32, Bjorn Munch wrote:
> On 09/09 14.40, Sunanda Menon wrote:
> > Hi ,
> >
> > Please review the code changes for 6693315: bump mysql from 5.0.45 to
> > latest 5.0.* at
> > http://cr.opensolaris.org/~sunandam/6693315/ and let me know your
> > comments ASAP.
>
> I just discovered th
On 09/10/08 13:31, Bjorn Munch wrote:
> On 10/09 09.25, Sunanda Menon wrote:
>
>> On 09/09/08 16:43, Bjorn Munch wrote:
>>
>>> On 09/09 14.40, Sunanda Menon wrote:
>>>
>>>
Hi ,
Please review the code changes for 6693315: bump mysql from 5.0.45 to
latest 5.0.*
On 10/09 09.25, Sunanda Menon wrote:
> On 09/09/08 16:43, Bjorn Munch wrote:
> >On 09/09 14.40, Sunanda Menon wrote:
> >
> >>Hi ,
> >>
> >>Please review the code changes for 6693315: bump mysql from 5.0.45 to
> >>latest 5.0.* at
> >>http://cr.opensolaris.org/~sunandam/6693315/ and let me know y
10 matches
Mail list logo
