[webstack-discuss] Code Review for CR 6781332 - Update Apache HTTP Server to 2.2.11

2009-01-29 Thread Seema Alevoor
Thanks for the review. Regards, Seema. On 01/27/09 16:31, Nick Kew wrote: > Seema Alevoor wrote: >> Hi, >> >> Please review the webrev for CR 6781332 - Update Apache HTTP Server to >> 2.2.11 . >> >> http://cr.opensolaris.org/~seema/6781332/ > > I see an upgrade 2.2.9 to 2.2.11, and removal of o

[webstack-discuss] Code Review for CR 6781332 - Update Apache HTTP Server to 2.2.11

2009-01-28 Thread Seema Alevoor
Thanks Amanda, for reviewing the changes. > I've run through the webrev and it looks fine. The only comment I could > make is that you might want to consider dropping the write bit on any > new files that go into /usr, it's generally not needed and might be Instead of changing the permissions

[webstack-discuss] Code Review for CR 6781332 - Update Apache HTTP Server to 2.2.11

2009-01-28 Thread Jeff Trawick
Seema Alevoor wrote: > Hi, > > Please review the webrev for CR 6781332 - Update Apache HTTP Server to 2.2.11 > . > > http://cr.opensolaris.org/~seema/6781332/ > I reviewed the changes from the 2.2.9 integration and didn't see any surprises.

[webstack-discuss] Code Review for CR 6781332 - Update Apache HTTP Server to 2.2.11

2009-01-27 Thread Seema Alevoor
Hi, Please review the webrev for CR 6781332 - Update Apache HTTP Server to 2.2.11 . http://cr.opensolaris.org/~seema/6781332/ Thanks, Seema.

[webstack-discuss] Code Review for CR 6781332 - Update Apache HTTP Server to 2.2.11

2009-01-27 Thread Nick Kew
Seema Alevoor wrote: > Hi, > > Please review the webrev for CR 6781332 - Update Apache HTTP Server to 2.2.11 > . > > http://cr.opensolaris.org/~seema/6781332/ I see an upgrade 2.2.9 to 2.2.11, and removal of one local patch, which was incorporated upstream in 2.2.10, and is the (only) upstream

[webstack-discuss] Code Review for CR 6781332 - Update Apache HTTP Server to 2.2.11

2009-01-27 Thread Amanda Waite
Hi Seema, I've run through the webrev and it looks fine. The only comment I could make is that you might want to consider dropping the write bit on any new files that go into /usr, it's generally not needed and might be called out by other reviewers. Amanda Seema Alevoor wrote: > Hi, > > Plea