[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda Waite
Jyri Virkki wrote: > Amanda waite wrote: > >>> Noticed the rbac changes in SUNWlighttpd14r/prototype_com but didn't >>> notice where they're coming from? Also, is that part of the upstream >>> 1.4.21 update? >>> >> I learned this rbac stuff from doing code reviews, this is apparently >>

[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-24 Thread Amanda waite
Jyri Virkki wrote: > Amanda Waite wrote: > >> Hi there, >> >> >> Can I get a code review for updating Lighttpd to version 1.4.21 please. >> Webrev is here: >> >> http://cr.opensolaris.org/~tekgrrl/CR-6781455/ >> > > > I was going to ask about status of lighttpd-fix_mod_simple_vhost.patch

[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-23 Thread Jyri Virkki
Amanda waite wrote: > > >Noticed the rbac changes in SUNWlighttpd14r/prototype_com but didn't > >notice where they're coming from? Also, is that part of the upstream > >1.4.21 update? > > I learned this rbac stuff from doing code reviews, this is apparently > the correct way of updating rbac file

[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-23 Thread Jyri Virkki
Amanda Waite wrote: > > Hi there, > > > Can I get a code review for updating Lighttpd to version 1.4.21 please. > Webrev is here: > > http://cr.opensolaris.org/~tekgrrl/CR-6781455/ I was going to ask about status of lighttpd-fix_mod_simple_vhost.patch but went and read the CR and I see it is

[webstack-discuss] Code review for Lighttpd 1.4.21 update

2009-02-22 Thread Amanda Waite
Hi there, Can I get a code review for updating Lighttpd to version 1.4.21 please. Webrev is here: http://cr.opensolaris.org/~tekgrrl/CR-6781455/ Thanks Amanda