[webstack-discuss] Review: APR, APR-util and Apache updates

2008-09-25 Thread Seema Alevoor
Sriram Natarajan wrote: > Seema Alevoor wrote: > >> >> >>> - You are patching the following file : fix-libtool.sed with CC to point >>> to /opt/SUNWspro. Instead of depending on hard coded location, should >>> you not simply configure it to use the CC used by SFW build system ? >>> >>>

[webstack-discuss] Review: APR, APR-util and Apache updates

2008-09-24 Thread Seema Alevoor
Updated webrev is at http://cr.opensolaris.org/~seema/6544042 Thanks, Seema. On 09/24/08 14:23, Jyri Virkki wrote: > Seema Alevoor wrote: >> Hi Sriram, >> >> On 09/24/08 06:45, Sriram Natarajan wrote: >>> Seema > [...] > > Please regenerate and repost the webrev after addressing the comments > f

[webstack-discuss] Review: APR, APR-util and Apache updates

2008-09-24 Thread Seema Alevoor
Hi Sriram, On 09/24/08 06:45, Sriram Natarajan wrote: > Seema > > - You don't want to 'set -o xtrace' within install-* script. This was > recommend to me by SFW RE > Fine, will remove it. > - I see that you compile apr so that it can know about MySQL and > PostgreSQL libraries. Now, does an

[webstack-discuss] Review: APR, APR-util and Apache updates

2008-09-24 Thread Sriram Natarajan
Seema Alevoor wrote: > > >> - You are patching the following file : fix-libtool.sed with CC to point >> to /opt/SUNWspro. Instead of depending on hard coded location, should >> you not simply configure it to use the CC used by SFW build system ? >> >> /usr/src/cmd/apr/apr-1.3/Solaris/templat

[webstack-discuss] Review: APR, APR-util and Apache updates

2008-09-24 Thread Jyri Virkki
Seema Alevoor wrote: > > Hi Sriram, > > On 09/24/08 06:45, Sriram Natarajan wrote: > > Seema [...] Please regenerate and repost the webrev after addressing the comments from Sriram's review, it'll make it easier for other reviewers to look at the latest. Thanks! -- Jyri J. Virkki - jyri.virkki

[webstack-discuss] Review: APR, APR-util and Apache updates

2008-09-23 Thread Sriram Natarajan
Seema - You don't want to 'set -o xtrace' within install-* script. This was recommend to me by SFW RE - I see that you compile apr so that it can know about MySQL and PostgreSQL libraries. Now, does any .so produced from apr depend on MySQL/PostgreSQL client libraries ? The reason I am aski

[webstack-discuss] Review: APR, APR-util and Apache updates

2008-09-18 Thread Seema Alevoor
Hi, Webrev is at http://cr.opensolaris.org/~seema/6544042/ . For each of the file, I have added a brief summary of the change. The main changes include: - Apache version update to 2.2.9 - Integration of APR and APR-util This webrev includes fixes for the following bugs. # 6544042 # 6714814 # 6703