[webstack-discuss] Review: Fix for CR 6670736

2008-08-20 Thread Jeff Trawick
Seema Alevoor wrote: > >> Were these large file settings added to >> * enable large file support in APR (needed with an Apache 2.0 build; not >> needed with Apache 2.2 build) >> or >> * fix an application or other issue in the way that APR enables large >> file support >> > > Unfortunately,

[webstack-discuss] Review: Fix for CR 6670736

2008-08-19 Thread Seema Alevoor
On 08/18/08 18:47, Jeff Trawick wrote: > Seema Alevoor wrote: >> On 08/14/08 20:51, Jeff Trawick wrote: >> >>> Seema Alevoor wrote: >>> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). Main changes include patches to apr_hints.m4 and apr_common.m4 >>

[webstack-discuss] Review: Fix for CR 6670736

2008-08-18 Thread Seema Alevoor
On 08/14/08 20:51, Jeff Trawick wrote: > Seema Alevoor wrote: >> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). >> >> Main changes include patches to apr_hints.m4 and apr_common.m4 >> apr_hints.m4 - to add the threaded flags. > Attached is an updated patch to solve: > *

[webstack-discuss] Review: Fix for CR 6670736

2008-08-18 Thread Jeff Trawick
Seema Alevoor wrote: > On 08/14/08 20:51, Jeff Trawick wrote: > >> Seema Alevoor wrote: >> >>> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). >>> >>> Main changes include patches to apr_hints.m4 and apr_common.m4 >>> apr_hints.m4 - to add the threaded flags. >>>

[webstack-discuss] Review: Fix for CR 6670736

2008-08-14 Thread Seema Alevoor
On 08/14/08 11:19, Seema Alevoor wrote: > > On 08/14/08 03:50, Basant Kukreja wrote: >> On Thu, Aug 14, 2008 at 01:36:22AM +0530, Seema Alevoor wrote: >>> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). >>> >>> Main changes include patches to apr_hints.m4 and apr_common.

[webstack-discuss] Review: Fix for CR 6670736

2008-08-14 Thread Jeff Trawick
Seema Alevoor wrote: > On 08/14/08 02:20, Jeff Trawick wrote: > >> Seema Alevoor wrote: >> >>> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). >>> >>> Main changes include patches to apr_hints.m4 and apr_common.m4 >>> apr_hints.m4 - to add the threaded flags. >>> >>

[webstack-discuss] Review: Fix for CR 6670736

2008-08-14 Thread Seema Alevoor
On 08/14/08 02:20, Jeff Trawick wrote: > Seema Alevoor wrote: >> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). >> >> Main changes include patches to apr_hints.m4 and apr_common.m4 >> apr_hints.m4 - to add the threaded flags. >> >> apr_common.m4 - to use the Sun compiler

[webstack-discuss] Review: Fix for CR 6670736

2008-08-14 Thread Jeff Trawick
Seema Alevoor wrote: > I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). > > Main changes include patches to apr_hints.m4 and apr_common.m4 > apr_hints.m4 - to add the threaded flags. Attached is an updated patch to solve: * We can't change default for --enable-threads * Hide

[webstack-discuss] Review: Fix for CR 6670736

2008-08-14 Thread Seema Alevoor
On 08/14/08 03:50, Basant Kukreja wrote: > On Thu, Aug 14, 2008 at 01:36:22AM +0530, Seema Alevoor wrote: >> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). >> >> Main changes include patches to apr_hints.m4 and apr_common.m4 >> apr_hints.m4 - to add the threaded flags. >

[webstack-discuss] Review: Fix for CR 6670736

2008-08-14 Thread Seema Alevoor
I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). Main changes include patches to apr_hints.m4 and apr_common.m4 apr_hints.m4 - to add the threaded flags. apr_common.m4 - to use the Sun compiler's flag, "-xM" to generate makefile dependencies. Since, for httpd we use the b

[webstack-discuss] Review: Fix for CR 6670736

2008-08-13 Thread Jeff Trawick
Seema Alevoor wrote: > I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). > > Main changes include patches to apr_hints.m4 and apr_common.m4 > apr_hints.m4 - to add the threaded flags. > > apr_common.m4 - to use the Sun compiler's flag, "-xM" to generate > makefile dependenci

[webstack-discuss] Review: Fix for CR 6670736

2008-08-13 Thread Basant Kukreja
On Thu, Aug 14, 2008 at 01:36:22AM +0530, Seema Alevoor wrote: > I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ). > > Main changes include patches to apr_hints.m4 and apr_common.m4 > apr_hints.m4 - to add the threaded flags. > > apr_common.m4 - to use the Sun compiler's fl

[webstack-discuss] Review: Fix for CR 6670736

2008-08-12 Thread Basant Kukreja
I agree with Jeff's concern that we should add "-mt" in apr rather than in apache. Sriram, Regarding your concern that some customer may not want to compile their application/module with -mt. * All apache modules which prefork mpm loads are compiled with "-mt" so it won't have any effect if cus

[webstack-discuss] Review: Fix for CR 6670736

2008-08-12 Thread Seema Alevoor
Jeff Trawick wrote: > Sriram Natarajan wrote: >> Jeff - You have some valid points. If you notice the some of the >> comments history in this bug - 6670736 - this point was indeed discussed. > Does this show the comments history? > http://bugs.opensolaris.org/view_bug.do?bug_id=6670736 (I do

[webstack-discuss] Review: Fix for CR 6670736

2008-08-12 Thread Jeff Trawick
Seema Alevoor wrote: > >> It sounds to me like the APR hard-coding of flags for threads on Solaris >> should look like: >> >> if !disable-threads >> if $CC -flags | grep -- '^-mt.*multi-threaded' >/dev/null 2>&1 >> use -mt for compiling and linking >> else >> use -D_POSIX_PTHREAD_SEMA

[webstack-discuss] Review: Fix for CR 6670736

2008-08-11 Thread Jeff Trawick
Sriram Natarajan wrote: > Jeff - You have some valid points. If you notice the some of the > comments history in this bug - 6670736 - this point was indeed discussed. Does this show the comments history? http://bugs.opensolaris.org/view_bug.do?bug_id=6670736 (I don't see the comments, or any

[webstack-discuss] Review: Fix for CR 6670736

2008-08-11 Thread Jeff Trawick
Seema Alevoor wrote: > I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736 ). > This fix also includes a change in the compiler optimization level to -xO4 > (same as that of CoolStack). > > Regarding the change for -mt: APR already uses -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT,

[webstack-discuss] Review: Fix for CR 6670736

2008-08-11 Thread Sriram Natarajan
Jeff - You have some valid points. If you notice the some of the comments history in this bug - 6670736 - this point was indeed discussed. But, some one pointed out why we could have '-mt' set within our project Makefile to avoid any misinterpretation. Also, please note that in our environment,

[webstack-discuss] Review: Fix for CR 6670736

2008-08-08 Thread Seema Alevoor
I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736 ). This fix also includes a change in the compiler optimization level to -xO4 (same as that of CoolStack). Kindly review. Thanks, Seema. Seema Alevoor wrote: > Hi, > > Please review the fix for CR 6670736 (apache worker mpm n

[webstack-discuss] Review: Fix for CR 6670736

2008-06-11 Thread Seema Alevoor
Hi, Please review the fix for CR 6670736 (apache worker mpm needs to be compiled with -mt). Webrev is at http://cr.opensolaris.org/~seema/6670736 Thanks, Seema.