Re: [Wengophone-devel] Pager functionality

2007-04-24 Thread Aurélien Gâteau
Vadim Lebedev a écrit : It is much better to have couple of phrases of comments in free-flow format in 2-3 lines, than a 'beautiful' comment templates on half a page, which often make impossible to see the comment and function body together on the monitor. ( Of course there is another reason

Re: [Wengophone-devel] Pager functionality

2007-04-24 Thread Vadim Lebedev
Aurélien Gâteau wrote: Vadim Lebedev a écrit : It is much better to have couple of phrases of comments in free-flow format in 2-3 lines, than a 'beautiful' comment templates on half a page, which often make impossible to see the comment and function body together on the monitor. ( Of course

Re: [Wengophone-devel] Pager functionality

2007-04-24 Thread Aurélien Gâteau
Vadim Lebedev a écrit : Hello Vadim, Just wanted to point out two things about Doxygen comments: First: if I'm not mistaken, OpenWengo project coding style says that Doxygen comments should be in .h files, so they should not annoy you when reading source code. Second: if you haven't tried

Re: [Wengophone-devel] Pager functionality

2007-04-24 Thread Dave Neary
Hi, Vadim Lebedev wrote: I believe that what you see as amajor drawback is MAJOR ADVANTAGE instead. This way a person have to try something differrent that he is doing usually which gives him a chance to learn something new and become better coder. The important thing that it comes in small

Re: [Wengophone-devel] Pager functionality

2007-04-24 Thread Vadim Lebedev
Dave, thanks for chiming in, Dave Neary wrote: Hi, Vadim Lebedev wrote: I believe that what you see as amajor drawback is MAJOR ADVANTAGE instead. This way a person have to try something differrent that he is doing usually which gives him a chance to learn something new and become better

Re: [Wengophone-devel] Pager functionality

2007-04-23 Thread Vadim Lebedev
Vadim Lebedev wrote: Hello, I'm attaching a patch which implement Pager functionality (sending SMS using SIP/SMS gateway) The patch is against branch wengophone-2.1 The patch does not touch the GUI stuff only libs/imwrapper and libs/sipwrapper it does not modify existing

Re: [Wengophone-devel] Pager functionality

2007-04-23 Thread Philippe BERNERY
Le 23 avr. 07 à 16:48, Vadim Lebedev a écrit : Hello, I suppose that the silence on this subject should be interpreted as lack of objections So i'm going to commit it tomorrow Vadim, I have some comments on your code: - You wrote a tolowercase method, which exists in the String

Re: [Wengophone-devel] Pager functionality

2007-04-23 Thread Vadim Lebedev
Philippe BERNERY wrote: Le 23 avr. 07 à 16:48, Vadim Lebedev a écrit : Hello, I suppose that the silence on this subject should be interpreted as lack of objections So i'm going to commit it tomorrow Vadim, I have some comments on your code: - You wrote a tolowercase method,

Re: [Wengophone-devel] Pager functionality

2007-04-23 Thread Philippe BERNERY
Le 23 avr. 07 à 18:23, Vadim Lebedev a écrit : - You wrote a tolowercase method, which exists in the String class of owutil. You should use this method instead of using yours You're right, meanwhile i've spent week-end browsing through boost docs, and i've found in strings/algorithm.hpp

Re: [Wengophone-devel] Pager functionality

2007-04-23 Thread Vadim Lebedev
Philippe BERNERY wrote: Le 23 avr. 07 à 18:23, Vadim Lebedev a écrit : - You wrote a tolowercase method, which exists in the String class of owutil. You should use this method instead of using yours You're right, meanwhile i've spent week-end browsing through boost docs, and i've found in

[Wengophone-devel] Pager functionality

2007-04-18 Thread Vadim Lebedev
Hello, I'm attaching a patch which implement Pager functionality (sending SMS using SIP/SMS gateway) The patch is against branch wengophone-2.1 The patch does not touch the GUI stuff only libs/imwrapper and libs/sipwrapper it does not modify existing functionality. I'd like