[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Update of patch #1148 (project wesnoth): Open/Closed:Open => Closed ___ Reply to this item at: ___ Message se

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Update of patch #1148 (project wesnoth): Status: In Progress => Done ___ Reply to this item at: ___ Message po

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #10, patch #1148 (project wesnoth): I have implemented the suggestion of comment#9. This patch is incremental to the last submitted one. I have added a t_match for forests, hills, mountains and swamps. I put them in terrain_translation.cpp/hpp, since it already contains several

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Update of patch #1148 (project wesnoth): Status:Done => In Progress ___ Reply to this item at: ___ Message po

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #9, patch #1148 (project wesnoth): While this patch should work, it would be better to avoid a hard-coded t_list of terrains as follows: 1. create a t_translation::t_match which will match all forests (do this outside the main loop if possible to avoid re-creating it each ti

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Update of patch #1148 (project wesnoth): Status:None => Done ___ Follow-up Comment #8: I'll commit as is, it's pretty good, all my previous idas would be great, if you had time fo

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #7, patch #1148 (project wesnoth): I attached a patch containing the label display fix only. (file #5559) ___ Additional Item Attachment: File name: label_display_fix_only.patch Size:0 KB

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #6, patch #1148 (project wesnoth): I attached a new version of the patch. It (hopefully!) fixes all style issues. Additionally, I improved the labeling for forests and swamps: Single-tile landforms are no longer labeled, and large landforms get multiple labels. (file #5556)

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Update of patch #1148 (project wesnoth): Assigned to:None => boucman ___ Reply to this item at: ___ Message po

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #5, patch #1148 (project wesnoth): you have uselessly modified the SConstruct file I don't understand why you have a village_name_mountain and a village_name_mountain2... reading the code didn't help me figure it out, you might want to either remove one of them or rename to a m

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #4, patch #1148 (project wesnoth): I didn't notice anything wrong with the patch, so I will just mention some style issues. Please check your indentation, there are still some places where you use spaces instead of tabs, and also the other way around. There are also some places

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Additional Item Attachment, patch #1148 (project wesnoth): File name: random_village_names4.jpeg Size:816 KB ___ Reply to this item at: ___ Message sent vi

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Additional Item Attachment, patch #1148 (project wesnoth): File name: random_village_names3.jpeg Size:766 KB ___ Reply to this item at: ___ Message sent vi

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Additional Item Attachment, patch #1148 (project wesnoth): File name: random_village_names2.jpeg Size:748 KB ___ Reply to this item at: ___ Message sent vi

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #3, patch #1148 (project wesnoth): I have attached a new version of random village naming. The first .patch file is obsolete. bug fixes: - village names (and all other labels of generated maps) do not show in game. This is fixed at mapgen_dialog.cpp:387 - random village names r

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #2, patch #1148 (project wesnoth): Please also check your patch for indentation; there are places where you use spaces instead of tabs, and vice versa; this is a bit of a mess. There are even places where you fill an empty line with spaces. Overall, I'm concerned by the approac

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

Follow-up Comment #1, patch #1148 (project wesnoth): ok, couple of comments don't worry the first reviews are usually full of seemongly useless stuff to correct please review your patch for minor useless changes like * adding a blank space at end of line 37 of mapgen.cpp * adding an extra spa

[Wesnoth-bugs] [patch #1148] random village naming: second sylabus

URL: Summary: random village naming: second sylabus Project: Battle for Wesnoth Submitted by: euschn Submitted on: Sunday 03/29/2009 at 16:12 Priority: 5 - Normal Status: Non