Follow-up Comment #7, patch #3846 (project wesnoth):
It is the leader's id, not the side one's. Sides don't normally have an id,
unless the wml author explicitely specifies a save_id. We could make
specifying a non-empty save_id for persistent sides mandatory. If it's not
given, stderr message
Follow-up Comment #5, patch #3846 (project wesnoth):
Did you notice that meanwhile ayne committed a different fix, probably without
knowing about this ? (commit 0d2eefaa8fa87d2861d0ed1011574fda5495)
I think one can't rely on at least one of [side]save_id= or [side]id= not
being empty. The
Follow-up Comment #6, patch #3846 (project wesnoth):
No, I didn't notice that. From what Crab_ said, I understood that patch such
as the first of mine (and probably ayne's patch?) is duplication of the
carryover code to other places, and it should be handled just there to avoid
maintenance
Follow-up Comment #4, patch #3846 (project wesnoth):
Correct version in attachment now.
(file #17941)
___
Additional Item Attachment:
File name: 0001-Fixed-default-100-gold-not-applied-on-the-campaign-s.patch
Size:2 KB
Follow-up Comment #3, patch #3846 (project wesnoth):
The carryover code was not called, because the sides were not initialised in
the beginning of the play_campaign function. I created a loop that adds the
teams not present.
Patch attached
(file #17918)
URL:
http://gna.org/patch/?3846
Summary: Fixed bug #20734: Default 100 gold is applied when
gold isn't specified in scenario.cfg
Project: Battle for Wesnoth
Submitted by: pl_kolek
Submitted on: Fri 12 Apr 2013 12:08:30 PM GMT
Follow-up Comment #1, patch #3846 (project wesnoth):
I also added gold=100 for SoF:1 for clarity.
I rather wouldn't want that (from the UMC author point of view). Using
conventions in mainline tends to outsource workload onto UMC authors, since
their addons have the more unusual wml then. Only
