[Wesnoth-dev] possible game_events cleanup

2005-03-06 Thread Yann Dirson
While studying my wesnoth dependency graph[1], I found strange that config has a dependency on game_events. It looks like the only real need is a single call to game_events::get_variable_const(), so I had a close look at game_envents in the hope of separating variables in their own file. The

Re: [Wesnoth-dev] possible game_events cleanup

2005-03-06 Thread Guillaume Melquiond
On Sun, 6 Mar 2005 17:06:23 +0100, Yann Dirson [EMAIL PROTECTED] wrote: While studying my wesnoth dependency graph[1], I found strange that config has a dependency on game_events. It looks like the only real need is a single call to game_events::get_variable_const(), so I had a close look at

Re: [Wesnoth-dev] possible game_events cleanup

2005-03-06 Thread Yann Dirson
On Sun, Mar 06, 2005 at 05:33:37PM +0100, Guillaume Melquiond wrote: On Sun, 6 Mar 2005 17:06:23 +0100, Yann Dirson [EMAIL PROTECTED] wrote: While studying my wesnoth dependency graph[1], I found strange that config has a dependency on game_events. It looks like the only real need is a

Re: [Wesnoth-dev] possible game_events cleanup

2005-03-06 Thread David White
Yann Dirson wrote: The thing that strikes me much in game_events is that game_events::manager is not a class, but a struct, whose ctor and dtor deal with variables in the anonymous namespace, instead of using object members. The whole thing therefor looks a bit non-reentrant - is there a

Re: [Wesnoth-dev] Top panel

2005-03-06 Thread Asa Swain
Personally I like the top panel the way it is. The time of day image is a nice break between the map and the unit info. And the order of the gold, income, expenses etc. along the top makes sense to me. Mainly I'm just used to the interface becuase it has been the same for over a year, but I don't

[Wesnoth-dev] I'm back!

2005-03-06 Thread Alex Turner
Well, after 3 months of constant college work and studying and things that aren't Wesnoth, my workload has finally gotten to the point where I can start thinking of contributing to this game which I love once again. I am in the process of checking out CVS to gain some understanding of what I

Re: [Wesnoth-dev] I'm back!

2005-03-06 Thread Isaac Clerencia
On Monday, 7 de March de 2005 00:39, Alex Turner wrote: WO! I'm back! -Alex Turner aka AT Welcome back Alex :) -- Isaac Clerencia [EMAIL PROTECTED] Warp Networks         http://www.warp.es María de Luna 11, 50018 Zaragoza, Spain pgpJjplJYbm4o.pgp Description: PGP signature

Re: [Wesnoth-dev] Top panel

2005-03-06 Thread Richard Kettering
The only thing that *needs* changing, IMO, was one of the things Darth Fool suggested doing - moving the terrain/defense info below the map/time of day images. That is the only change I would make, but it is a change I would strongly suggest. It seems to me that most users (including myself),