[Wesnoth-dev] Asserts

2007-12-02 Thread Mark de Wever
Hi, At the moment we use wassert which is mainly a wrapper to assert. But it has an option to be used for platforms which don't support assert. Since we also have code which uses the normal asserts I assume the code for wassert to be obsolete. If there are no objections I'll remove wassert.hpp and

Re: [Wesnoth-dev] Asserts

2007-12-02 Thread David Philippi
Am Sonntag 02 Dezember 2007 schrieb Mark de Wever: > titlescreen. This avoids terminations due to asserts, which users see as > crashes. I'll look into converting the existing code to use this kind of > assert and also look at which asserts should be a runtime check. I guess in 1.3.x / 1.5.x etc.

Re: [Wesnoth-dev] Asserts

2007-12-02 Thread dave
Thank you for taking time to do this; I agree completely with your rationale and approach. As a general note on asserts, I'd like to remind people that an assert should only be used for a condition that is NEVER logically able to happen, regardless of the program's input. A failed assertion