Re: removing that pesky transient boolean attached from detachable models

2007-01-29 Thread Igor Vaynberg
before johan has a chance to poke me, ldm.detach should read transientModelObject = IDetachable.DETACHED; not transientModelObject = null; -igor On 1/29/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: jonathan and i have been brainstorming about removing private transient boolean attached=

optimizing serialized state: optimizing component

2007-01-29 Thread Igor Vaynberg
yet another brainstorm on the subject a big percentage of components do not have metadata/behaviors/markupattributes/markupindex/etc, but we always write them out (even if null). what if we allocate a few more component flags and use custom serialization to not write those out based on flags. thi

optimizing serialized state: model serialization codecs idea

2007-01-29 Thread Igor Vaynberg
another idea to optimize serialization state from jon and i allow an easy way to override model serialization a simple example: class EntityModel extends LoadableDetachableModel { private long id; //standard junk } now when this is serialized you get a bunch of junk like the class header,

removing that pesky transient boolean attached from detachable models

2007-01-29 Thread Igor Vaynberg
jonathan and i have been brainstorming about removing private transient boolean attached=false from our detachable models, and after an hour here is what we came up with (see attachment). i know we use some custom serialization for models, etc so do you guys this is going to interfere with that? i

Re: model hierarchy cleanup in 2.0

2007-01-29 Thread Igor Vaynberg
just checked it in On 1/29/07, Johan Compagner <[EMAIL PROTECTED]> wrote: +1 (both in 1.3 and 2.0?) 2.0 only - dont people read subjects anymore! :) but isn't AbstractModel kind of usefull? Thats just one basic impl with methods you mostly don't need when making a quick anon inner class

Re: [VOTE] Release Wicket 1.2.5

2007-01-29 Thread Eelco Hillenius
[ x ] yes, bug-b-gone my Wicket [ ] no, I still have some critters to deal with Eelco

Re: [VOTE] Release Wicket 1.2.5

2007-01-29 Thread Frank Bille
On 1/29/07, Frank Bille <[EMAIL PROTECTED]> wrote: PS. is 1.2.x already under the bamboo build umbrella? > Nope not yet. Let me add them. http://www.wicketstuff.org/bamboo/browse/WICKET12X Frank

Re: which version to use for new website: 1.2.x vs 1.3 vs 2.0

2007-01-29 Thread Eelco Hillenius
Yeah, 1.3 is the best to go if you're ramping up for development now. Eelco On 1/29/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: i would go with 1.3 branch. 2.0 is still unstable and if you have a deadline i wouldnt go with it -igor On 1/29/07, Alexei Sokolov <[EMAIL PROTECTED]> wrote: > >

Re: which version to use for new website: 1.2.x vs 1.3 vs 2.0

2007-01-29 Thread Igor Vaynberg
i would go with 1.3 branch. 2.0 is still unstable and if you have a deadline i wouldnt go with it -igor On 1/29/07, Alexei Sokolov <[EMAIL PROTECTED]> wrote: Hello wicket developers, I need your advise as to what version of wicket to use for our new website. Currently, we have some code usi

which version to use for new website: 1.2.x vs 1.3 vs 2.0

2007-01-29 Thread Alexei Sokolov
Hello wicket developers, I need your advise as to what version of wicket to use for our new website. Currently, we have some code using 1.2.3, but we are planning to start coding much more aggressively very soon. We are trying to hit March 30 deadline for our beta version, and so far it looks li

Re: VOTE: remove display tag examples

2007-01-29 Thread Eelco Hillenius
+1 Eelco On 1/29/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: these examples were written before dataview/datatable and no longer demonstrate best practices -igor

Re: VOTE: remove display tag examples

2007-01-29 Thread Martijn Dashorst
+1 as examples of how to do it manually they are workable. They do have one nice feature IIRC: csv export (http://wicketstuff.org/wicket13/displaytag;jsessionid=F6260A26A9135AA19FDC653B436C4E76?wicket:bookmarkablePage=%3Awicket.examples.displaytag.ExamplePse). Martijn On 1/29/07, Igor Vaynberg

Re: VOTE: remove display tag examples

2007-01-29 Thread Igor Vaynberg
+1 -igor On 1/29/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: these examples were written before dataview/datatable and no longer demonstrate best practices -igor

VOTE: remove display tag examples

2007-01-29 Thread Igor Vaynberg
these examples were written before dataview/datatable and no longer demonstrate best practices -igor

Practice 1.3-beta1 release using 1.2.5

2007-01-29 Thread Martijn Dashorst
However, I'll publish the distributions before I deploy to an external repository. Say that we do the final on monday, after *we* checked the release (better practice our skills at that with this release)? I'll do the release using our old distribution packages. Can anyone download those and chec

Re: [VOTE] Release Wicket 1.2.5

2007-01-29 Thread Igor Vaynberg
On 1/29/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: [x] yes, bug-b-gone my Wicket PS. is 1.2.x already under the bamboo build umbrella? not yet but feel free to set it up :) -igor Martijn -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.

Re: [VOTE] Release Wicket 1.2.5

2007-01-29 Thread Martijn Dashorst
Fixing the pom is part of the release process. So that can't be done upfront. Martijn On 1/29/07, Johan Compagner <[EMAIL PROTECTED]> wrote: aren't there any any any other really really need to have fixes? (except now have the right pom also ;) ) because i really hope that 1.2 could be finishe

Re: [VOTE] Release Wicket 1.2.5

2007-01-29 Thread Johan Compagner
aren't there any any any other really really need to have fixes? (except now have the right pom also ;) ) because i really hope that 1.2 could be finished then! johan On 1/29/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: It is almost februari and we need some time to resolve a vote (and pr

Re: [VOTE] Release Wicket 1.2.5

2007-01-29 Thread Frank Bille
On 1/29/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: [x] yes, bug-b-gone my Wicket [ ] no, I still have some critters to deal with PS. is 1.2.x already under the bamboo build umbrella? Nope not yet. Let me add them. Frank

[VOTE] Release Wicket 1.2.5

2007-01-29 Thread Martijn Dashorst
It is almost februari and we need some time to resolve a vote (and prepare a release). This is a vote to release the 1.2.5 Wicket branch on sourceforge, to fix some nasty hairy bugs out there. Are all issues resolved for 1.2.5? Release Notes - Wicket - Version 1.2.5 Bug: * [WICKET-188] - Header

Re: Wicket and OSGi

2007-01-29 Thread Patrick MauiƩ
Hi all, Hi all, I have been using WicketFilter for an OSGI-based application, and it's actually are very small difference to the current version. I extended IWebApplicationFactory and for the method createApplication() implemented like this public WebApplication createApplication(WicketS

Re: WebResponse#redirect(String)

2007-01-29 Thread Johan Compagner
+1 i hate exceptions anyway. Dont want to see them anywhere. johan On 1/23/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: we are seeing this usually cause by socketclosedexception from nio, so its not like we can recover anyways +1 to just log it -igor On 1/22/07, Eelco Hillenius <[EMAIL PR

Re: Getting rid of filterPath?

2007-01-29 Thread Johan Compagner
> maybe we should just parse web.xml and rip out the mapping. we already have > an xml parser :P Yeah, I've just thought about doing that, and it certainly works, although it's a bit ugly. However, I've thought a bit harder, and I'm not convinced it's actually necessary. I think we can resolve i

DefaultRequestTargetResolverStrategy.resolveListenerInterfaceTarget method

2007-01-29 Thread Johan Compagner
Hi, We do this in that method (last few lines) if (component == null || !component.isEnabled() || !component.isVisibleInHierarchy()) { log .info("component not enabled or visible, redirecting to calling page, component: "

Re: Getting rid of filterPath?

2007-01-29 Thread Al Maw
Igor Vaynberg wrote: On 1/27/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote: * you repeat yourself and often forget to keep in sync with filter mapping maybe we should just parse web.xml and rip out the mapping. we already have an xml parser :P Yeah, I've just thought about doing that,

Re: model hierarchy cleanup in 2.0

2007-01-29 Thread Johan Compagner
+1 (both in 1.3 and 2.0?) but isn't AbstractModel kind of usefull? Thats just one basic impl with methods you mostly don't need when making a quick anon inner class johan On 1/28/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: we have way too many base classes that arent really useful. we can