Re: [DISCUSS] Deprecation in 1.3

2007-03-06 Thread Eelco Hillenius
Agreed. Go ahead. Mostly me put them in there anyway. Eelco On 3/6/07, Frank Bille <[EMAIL PROTECTED]> wrote: I think that we have some places in 1.3 where we shouldn't deprecate the API. This is areas where the deprecation says "Will be removed/moved in 2.0". I think it is a bit annoying to d

Re: generics in Wicket

2007-03-06 Thread Eelco Hillenius
But if we backport the model changes then that is done inside the model and that is much much cleaner (i am +1 for backporting that to 1.3) +1 too. Especially considering the case you just described: ugly! :) Eelco

[DISCUSS] Deprecation in 1.3

2007-03-06 Thread Frank Bille
I think that we have some places in 1.3 where we shouldn't deprecate the API. This is areas where the deprecation says "Will be removed/moved in 2.0". I think it is a bit annoying to develop an application and suddenly find that I can't get rid of some deprecation warnings because there is no alte

Re: generics in Wicket

2007-03-06 Thread Johan Compagner
getModelObject has (in 1.3 not in 2.0) really a better function then getModel().getObject() because getModelObject knows what to put in the for example this is very different: Form form = new Form("form", new CompoundModel(xxx)); Textfield tf = new Textfield("tf"); form.add(tf); now if

Re: generics in Wicket

2007-03-06 Thread Eelco Hillenius
no i am not pro for degenerifying it. I like the getModelObject() What is so great about that method, and why don't you just directly work with the objects the models work on? And why not getModel().getObject? But i am curious about where people talk to is it just the model or are people go th

Re: generics in Wicket

2007-03-06 Thread Johan Compagner
no i am not pro for degenerifying it. I like the getModelObject() and that we have to do this: TextField integerTextField = new TextField(this,"integerProperty", Integer.class); is just suns fault of that stupid erasure :( But i am curious about where people talk to is it just the model or are

generics in Wicket

2007-03-06 Thread Eelco Hillenius
Hi, I think we went overboard applying generics in Wicket. Things like: TextField integerTextField = new TextField(this, "integerProperty", Integer.class); are just horrible imo. Sure, you can do: Integer i = integerTextField.getModelObject(); instead of: Integer i = (Integer)integerTextFiel

AjaxSubmitButton in Panel inside ModalWindow in a Form

2007-03-06 Thread Al Maw
AjaxSubmitButton in a ModalWindow using a Panel as content doesn't work if the ModalWindow component is itself embedded in a Form. The issue is that ModalWindow tacks its content on as a on the element, which places it outside the original element. If we fix ModalWindow to inject its Panel

RE: Shouldn't wicket.markup.html.basic.Label extend WebComponent?

2007-03-06 Thread Stefan Lindner
Shall I create an issue or will this be fixed en passant? Appended is a version ov Label that I testes with the current svn version of wicket 2.0 Stefan Lindner -- The code without the license header package wicket.markup.html.basic; import wicket.MarkupContainer; import w

Re: Shouldn't wicket.markup.html.basic.Label extend WebComponent?

2007-03-06 Thread Johan Compagner
Yes label model object is not used just for strings so it should be Label johan On 3/6/07, Martin Benda <[EMAIL PROTECTED]> wrote: Hi, a Label can have a model of any type, so that you can easily display Dates, Booleans, Numbers and so on... IConverters (via getModelObjectAsString() call) ar

Re: Shouldn't wicket.markup.html.basic.Label extend WebComponent?

2007-03-06 Thread Martin Benda
Hi, a Label can have a model of any type, so that you can easily display Dates, Booleans, Numbers and so on... IConverters (via getModelObjectAsString() call) are responsible for converting these model objects to displayable strings in a locale-sensitive manner. So "public class Label extends

Shouldn't wicket.markup.html.basic.Label extend WebComponent?

2007-03-06 Thread Stefan Lindner
In Wicket 2 the Label class is defined as public class Label extends WebComponent The Label class inhertis setModelObject from Comonent through the genetric class WebComponent. The method public final Component setModelObject(final T object) is generic too. Now If we have code