Re: WICKET-365 - Go from setVisible(false) to setVisible(true) on a component in ajax does not work

2007-03-07 Thread Frédéric Bertin
well, from a user point of view, the fact that you can't make a component visible using Ajax by simply doing: component.setVisible(true) target.addComponent(component) is perceived as a bug. And I can't believe you guys won't find something smarter for Wicket than using a surrounding container

Re: Going from setVisible(false) to setVisible(true) does not work without surounding element

2007-03-19 Thread Frédéric Bertin
Martijn Dashorst wrote: So you mean: Label l = Label("foo", "hello"); renders: hello ... some ajax stuff, or a normal page render: l.setVisible(false); renders: not @wicket:id, but just @id, because the Label should have setOutputMarkupId(true) to be refreshed with ajax Fred

Re: Going from setVisible(false) to setVisible(true) does not work without surounding element

2007-03-19 Thread Frédéric Bertin
Martijn Dashorst wrote: Currently everybody assumes (correctly) that the element is completely removed (Ajax and non-Ajax), i.e. not present in the final markup. This means that scripts that iterate through the dom, or check for the document.getElementById() == null will fail if we implement this

Re: Going from setVisible(false) to setVisible(true) does not work without surounding element

2007-03-19 Thread Frédéric Bertin
hat do you mean by security problem? >> > > > >> > > > >> > > > >> > > > If the the component that is set to none visible is none visible >> > > > because of >> > > > security >> > > > So it has da

Re: Going from setVisible(false) to setVisible(true) does not work without surounding element

2007-03-19 Thread Frédéric Bertin
and @deprecation for that. This change doesn't have any of those safeguards. Martijn On 3/19/07, Frédéric Bertin <[EMAIL PROTECTED]> wrote: Martijn Dashorst wrote: > Currently everybody assumes (correctly) that the element is completely > removed (Ajax and non-Ajax), i.e. not pres

Re: Going from setVisible(false) to setVisible(true) does not work without surounding element

2007-03-19 Thread Frédéric Bertin
r > > something similiar, that takes more space then just one bit in flags. > > > > I think we can just make a getter, that by default returns the value > > from application settings. And you can override that for your > > component, if you want something differen

Re: Going from setVisible(false) to setVisible(true) does not work without surounding element

2007-03-19 Thread Frédéric Bertin
require an enum, int, byte or > > something similiar, that takes more space then just one bit in flags. > > > > I think we can just make a getter, that by default returns the value > > from application settings. And you can override that for your > > component, if

Re: Going from setVisible(false) to setVisible(true) does not work without surounding element

2007-03-19 Thread Frédéric Bertin
nk deprecating set/isVisible is the >> way to >> > > go. Plus there are other reasons: As now we use one flag for visible >> > > status. With your approach you'd require an enum, int, byte or >> > > something similiar, that takes more space the