Re: WebExternalResourceStream (Was: svn commit: r528885 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/resource/WebExternalResourceStream.java)

2007-04-15 Thread Jean-Baptiste Quenot
* Johan Compagner: > how is this class (WebExternalResourceStream.java) different to: > UrlResourceStream ?? * UrlResourceStream implements IResource for URLs, uses URL.openConnection() * WebExternalResourceStream implements IResource for a webapp URI, uses the servlet context > and how is Web

Re: WebExternalResourceStream (Was: svn commit: r528885 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/resource/WebExternalResourceStream.java)

2007-04-15 Thread Jean-Baptiste Quenot
The other possibility is to have a null value for IResourceStream.length(), like -1, to decide whether to set the header or not. The RFC says that this Content-Length SHOULD be sent http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.13 That means it's recommended, but not mandatory. --

Re: WebExternalResourceStream (Was: svn commit: r528885 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/resource/WebExternalResourceStream.java)

2007-04-15 Thread Johan Compagner
On 4/15/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote: * Johan Compagner: > how is this class (WebExternalResourceStream.java) different to: > UrlResourceStream ?? * UrlResourceStream implements IResource for URLs, uses URL.openConnection () * WebExternalResourceStream implements IResourc

Re: WebExternalResourceStream (Was: svn commit: r528885 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/resource/WebExternalResourceStream.java)

2007-04-15 Thread Johan Compagner
content lenght is used for all kind of things. For example caching. So it is very recommended to set it. johan On 4/15/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote: The other possibility is to have a null value for IResourceStream.length(), like -1, to decide whether to set the header o

Re: WebExternalResourceStream (Was: svn commit: r528885 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/resource/WebExternalResourceStream.java)

2007-04-15 Thread Jean-Baptiste Quenot
* Johan Compagner: > > Which one should be dropped? The ResourceStreaMRequestTarget? > That will break all kinds of things. Then just adapt it the way you want. Don't take "drop" literally, I mean make WebExternalResourceRequestTarget reuse the WebExternalResourceStream. I could change the imple

Re: WebExternalResourceStream (Was: svn commit: r528885 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/resource/WebExternalResourceStream.java)

2007-04-16 Thread Jean-Baptiste Quenot
* Jean-Baptiste Quenot: > * Johan Compagner: > > > > Which one should be dropped? The ResourceStreaMRequestTarget? > > That will break all kinds of things. Then just adapt it the way you want. > > Don't take "drop" literally, I mean make > WebExternalResourceRequestTarget reuse the > WebExternalR