Re: Wicket 2 - Response implements Serializable?!

2006-11-22 Thread Eelco Hillenius
Sigh... seems I had some outgoing changes still too. Programming in the evenings != a good idea. Eelco On 11/22/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: Yeah, sorry about that. Actually I made that change (at least I thought) so that only StringResponse implemented it. Anyway, it seems

Re: Wicket 2 - Response implements Serializable?!

2006-11-22 Thread Eelco Hillenius
Yeah, sorry about that. Actually I made that change (at least I thought) so that only StringResponse implemented it. Anyway, it seems the response ends up in the session somehow, so we have something to fix there. I got exceptions all over the place when I tried to work on my project yesterday.

Re: Wicket 2 - Response implements Serializable?!

2006-11-22 Thread Frank Bille
+1 On 11/22/06, Matej Knopp <[EMAIL PROTECTED]> wrote: Hi, I just update W2 and it doesn't compile, as the classes extended from Response don't declare serial version uid. So it seem that Eelco made response serializable. Johan and I think that it's a bad idea to have Response implements seria

Re: Re: Re: Wicket 2 - Response implements Serializable?!

2006-11-22 Thread Martijn Dashorst
And 1.x branch doesn't compile because of it. Martijn On 11/22/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: +1 As a side note, it is also in the 1.x branch Martijn On 11/22/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > yes +1 > > it doesn't make any sense to me that a response is seria

Re: Re: Wicket 2 - Response implements Serializable?!

2006-11-22 Thread Martijn Dashorst
+1 As a side note, it is also in the 1.x branch Martijn On 11/22/06, Johan Compagner <[EMAIL PROTECTED]> wrote: yes +1 it doesn't make any sense to me that a response is serialize (a response is more or less a outputstream) Everytime we did find a problem now it was a bug that a response

Re: Wicket 2 - Response implements Serializable?!

2006-11-22 Thread Johan Compagner
yes +1 it doesn't make any sense to me that a response is serialize (a response is more or less a outputstream) Everytime we did find a problem now it was a bug that a response object was kept around. So let it be not serializeable. A special subclass (like string response ok.. that could be

Wicket 2 - Response implements Serializable?!

2006-11-22 Thread Matej Knopp
Hi, I just update W2 and it doesn't compile, as the classes extended from Response don't declare serial version uid. So it seem that Eelco made response serializable. Johan and I think that it's a bad idea to have Response implements serializable. I personally have found numerous bugs just be