Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

2007-05-08 Thread Igor Vaynberg
what will people think??? :) http://papernapkin.org/pastebin/view/5915 -igor On 5/8/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: jcompagner Date: Tue May 8 07:44:07 2007 New Revision: 536209 URL: http://svn.apache.org/viewvc?view=revrev=536209 Log: stupid stupid stupid

Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

2007-05-08 Thread Matej Knopp
has, it was just one my commit that has upset him. I'm pretty sure the stupid stupid stupid stupid was a message for me :) -Matej On 5/8/07, Igor Vaynberg [EMAIL PROTECTED] wrote: what will people think??? :) http://papernapkin.org/pastebin/view/5915 -igor On 5/8/07, [EMAIL PROTECTED]

Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

2007-05-08 Thread Philip A. Chapman
At least he admits to mistakes, if a bit roughly. On Tue, 2007-05-08 at 09:40 -0700, Igor Vaynberg wrote: what will people think??? :) http://papernapkin.org/pastebin/view/5915 -igor On 5/8/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: jcompagner Date: Tue May 8

Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

2007-05-08 Thread Johan Compagner
only this time i think it was not you! It has to be me i think.. But how on earth that could pass me is beyond me because i do use that code! and i have here servoy solutions where i demonstrated requestFocus! very very strange.. On 5/8/07, Matej Knopp [EMAIL PROTECTED] wrote: has, it was

Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

2007-05-08 Thread Matej Knopp
It was me. You code didn't allow null component, i needed to disable setting focus, so i changed the code. But i didn't notice that i always pass null to javascript ;-) -Matej On 5/8/07, Johan Compagner [EMAIL PROTECTED] wrote: only this time i think it was not you! It has to be me i think..

Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

2007-05-08 Thread Johan Compagner
ahh stupid stupid stupid :) but why do this: final String id = component != null ? component.getMarkupId() : null; appendJavascript(Wicket.Focus.setFocusOnId(' + id + ');); instead of if (component != null) appendJavascript(Wicket.Focus.setFocusOnId(' +

Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

2007-05-08 Thread Matej Knopp
It's not. setFocusOnId just sets a javascript variable. It doesn't really set focus. What i wanted to do was to reset set the javascript variable to null. It does make sense. -Matej On 5/8/07, Johan Compagner [EMAIL PROTECTED] wrote: ahh stupid stupid stupid :) but why do this: