Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-06 Thread Johan Compagner
Then RequestTarget.cleanup() should also be called inside the lockBecause those are touching the page again (some do)Then we should move the RequestCycle.cleanup() method totally inside that block somehow.But then we are still not there.. Because what does this do: RequestCycle.prepare()    {      

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-06 Thread Eelco Hillenius
You are right of course. The requet (target) is only synced after the request cycle processor found out which request target it was. But, as that target is also being used for handling the calls to target components etc. we should not have sync problems. The problem here is that the call to cleanu

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-06 Thread Johan Compagner
yes but inside the request target everything is fine.It is synced (the response)But getting the request target and the cleanup after the request target are just not synced. So in wicket we need to take that into account like i did now by making dirty objects a thread local. johanOn 2/6/06, Igor Vay

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-06 Thread Igor Vaynberg
sounds like something to be fixed on our end. if i am writing a request target and say sync on session i should not be worrying about concurrency.-IgorOn 2/6/06, Johan Compagner <[EMAIL PROTECTED]> wrote: Huh?Why it doesn't work is pretty easy to understand...Sessions can be used just fine without

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-06 Thread Johan Compagner
Huh?Why it doesn't work is pretty easy to understand...Sessions can be used just fine without a lock. Because we do take a session long before we sync it.And we also use it (the cleanup call) long AFTER the sync that could happen. So when 2 request are comming in. there can be a sync lock somewhere

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-05 Thread Eelco Hillenius
I'm not sure whether that is the best solution. I think we should first find out why our session synchronization isn't working in this case. Eelco On 2/5/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > Is there more then one request happening at the same time? > Can you check that with a system

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-05 Thread Igor Vaynberg
ajax request target already returns session as its lock, why is this still happening?-IgorOn 2/5/06, Johan Compagner < [EMAIL PROTECTED]> wrote:Is there more then one request happening at the same time? Can you check that with a system.out somewhere or a breakpoint?It looks like 2 or more request a

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-05 Thread Mark Derricutt
On 2/6/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: Looks like a synchronization issue. Not a known one, but that's partof code that has been quite recently refactored. Could you tell us abit more about the ajax thingy you're using?I'm adding the component like:     Label totalTime = new Labe

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-05 Thread Johan Compagner
Is there more then one request happening at the same time?Can you check that with a system.out somewhere or a breakpoint?It looks like 2 or more request at the same time modifying the dirty objects List (pages and pagemaps) We could fix this by making the List a threadlocal or syncing on it everywh

Re: [Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-05 Thread Eelco Hillenius
Looks like a synchronization issue. Not a known one, but that's part of code that has been quite recently refactored. Could you tell us a bit more about the ajax thingy you're using? Eelco On 2/5/06, Mark Derricutt <[EMAIL PROTECTED]> wrote: > Hey all, I'm noticing a few > ConcurrentModification

[Wicket-user] ConcurrentModificationException during AJAX updates

2006-02-05 Thread Mark Derricutt
Hey all, I'm noticing a few ConcurrentModificationExceptions in my logs during an AJAX update (SelfUpdating behaviour) under wicket 1.2cvs-from-this-morning:16:55:56.499 WARN!! Exception for /app?path=1:feedback&interface=IBehaviorListener&behaviorId=0&random= 0.9183153983106074java.util.Concurrent