I created a playersmanager class and moved all player handling code in there.
As there are many code making use of the functions of editor_gamebase, i simply
delegated the work for now.
I left a few comments
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Y
Fixed :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug1204144/+merge/176688
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1204144.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to :
cghislai has proposed merging lp:~widelands-dev/widelands/minimap into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #846409 in widelands: "Improving the load game dialog"
https://bugs.launchpad.net/widelands/+bug/846409
Bug #1202146 in widelands:
Review: Approve
Looks good and works great. I also like those new icons.
Should there be such option for training sites as well, so we can choose to
train rookies or heroes ? I have no idea if the underlying logic could allow
this
--
https://code.launchpad.net/~widelands-dev/widelands/soldierse
About trainingsites: How should these options differ?
Currently, there is an option regarding whether the trainingsite attempts to
train least-trained guy or most-trained guy, if there are more than one tha
could be trained in a step. There is no UI for that.
Also, it would be relatively easy t
> Should there be such option for training sites as well, so we can choose to
> train rookies or heroes?
With teppos recent changes I think we have these bases covered - at least we
should gather some experience before we go ahead and tweak there again. So I
think for now we should not further t
Review: Needs Fixing
Some more comments here. I also changed some style and nits around. Also you
forgot to check in logic/playersmanager.[h|cc]. I also think the file should be
called players_manager.h and the class PlayersManager (though we are not very
consistent about this either - we defin
Review: Approve
The code lgtm. I haven't tested this though :).
--
https://code.launchpad.net/~widelands-dev/widelands/bug1204144/+merge/176688
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1204144.
___
Mailing
When you want to have another look, just ping me here.
--
https://code.launchpad.net/~widelands-dev/widelands/bug994712/+merge/176747
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug994712.
___
Mailing list: https:
Rejected:
widelands_17-ppa0-bzr6667+201307252101+~lucid1.dsc: Version older than that in
the archive. 1:17-ppa0-bzr6667+201307252101+~lucid1 <=
1:17-ppa0-bzr6665-201307241909~lucid1
===
If you don't understand why your files were rejected please send an email
to launchpad-us...@lists.launchpa
Rejected:
widelands_17-ppa0-bzr6667+201307252101+~precise1.dsc: Version older than that
in the archive. 1:17-ppa0-bzr6667+201307252101+~precise1 <=
1:17-ppa0-bzr6665-201307241914~precise1
===
If you don't understand why your files were rejected please send an email
to launchpad-us...@lists.la
Rejected:
widelands_17-ppa0-bzr6667+201307252100+~raring1.dsc: Version older than that in
the archive. 1:17-ppa0-bzr6667+201307252100+~raring1 <=
1:17-ppa0-bzr-201307241916~raring1
===
If you don't understand why your files were rejected please send an email
to launchpad-us...@lists.launc
Rejected:
widelands_17-ppa0-bzr6667+201307252101+~quantal1.dsc: Version older than that
in the archive. 1:17-ppa0-bzr6667+201307252101+~quantal1 <=
1:17-ppa0-bzr6665-201307241916~quantal1
===
If you don't understand why your files were rejected please send an email
to launchpad-us...@lists.la
Rejected:
widelands_17-ppa0-bzr6667+201307252101+~saucy1.dsc: Version older than that in
the archive. 1:17-ppa0-bzr6667+201307252101+~saucy1 <=
1:17-ppa0-bzr6665-201307241913~saucy1
===
If you don't understand why your files were rejected please send an email
to launchpad-us...@lists.launchpa
14 matches
Mail list logo
