cghislai has proposed merging lp:~widelands-dev/widelands/workarea_csite into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #803284 in widelands: "While building, show range of the building on
construction site"
https://bugs.launchpad.net/widelands
cghislai has proposed merging lp:~widelands-dev/widelands/wareslist_sizes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1205609 in widelands: "Wincondition scripts reloaded too often"
https://bugs.launchpad.net/widelands/+bug/1205609
Bug #12
The proposal to merge lp:~widelands-dev/widelands/wareslist_sizes into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/wareslist_sizes/+merge/178257
--
https://code.launchpad.net/~widelands-de
cghislai has proposed merging lp:~widelands-dev/widelands/wareslist_sizes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1205609 in widelands: "Wincondition scripts reloaded too often"
https://bugs.launchpad.net/widelands/+bug/1205609
Bug #12
Jens Beyer (Qcumber-some) has proposed merging
lp:~widelands-dev/widelands/boost-signals2 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1201081 in widelands: "Building with boost 1.54: "Boost.Signals is no
longer being maintained and is now dep
Review: Needs Fixing
Finally went over this. The use of InMemoryImage is fine as it never stays
around to be a problem with graphic system reinitialization.
--
https://code.launchpad.net/~widelands-dev/widelands/minimap/+merge/176945
Your team Widelands Developers is subscribed to branch
lp:~wi
chees -- me and the save comment button. I forgot to mention: I have some
comments and did some small fixes that you should review/address.
--
https://code.launchpad.net/~widelands-dev/widelands/minimap/+merge/176945
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widela
Review: Approve
I am slightly confused. Why does it say this is merged? Trunk does definitely
not contain the new code. Could it be that you branched and merged your
different branches from each other instead from trunk?
however, the code looks fine. Just a nit
upcast(Warehouse, wh, building);
Review: Approve
Easy enough I think. Factoring out the percent would have been nice, but I have
no clear idea how this could be done in a nice way, so I'll just shut my
foodhole and merge this.
Thanks!
--
https://code.launchpad.net/~widelands-dev/widelands/ship_progress/+merge/177318
Your team
The proposal to merge lp:~widelands-dev/widelands/ship_progress into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ship_progress/+merge/177318
--
https://code.launchpad.net/~widelands-dev/widelands/sh
Review: Approve
Seems fine to me. This is really only for debugging. Merging this.
--
https://code.launchpad.net/~widelands-dev/widelands/debug_window/+merge/177282
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/debug_window.
_
The proposal to merge lp:~widelands-dev/widelands/debug_window into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/debug_window/+merge/177282
--
https://code.launchpad.net/~widelands-dev/widelands/debu
Review: Approve
Compiles for me and the changes are very straightforward. Merged. Thanks for
looking into this Jens!
--
https://code.launchpad.net/~widelands-dev/widelands/boost-signals2/+merge/178361
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/boost-signa
The proposal to merge lp:~widelands-dev/widelands/boost-signals2 into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/boost-signals2/+merge/178361
--
https://code.launchpad.net/~widelands-dev/widelands/
14 matches
Mail list logo
