The proposal to merge lp:~widelands-dev/widelands/bug-1377394 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1377394/+merge/237172
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13
The proposal to merge lp:~widelands-dev/widelands/bug-1380307 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1380307/+merge/238083
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13
The proposal to merge lp:~hjd/widelands/remove-indentation-checker into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~hjd/widelands/remove-indentation-checker/+merge/238075
--
https://code.launchpad.net/~hjd/widelands/remove
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1377394/+merge/237172
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1377394.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
I very quick check showed that the lua_testsuite.wmf map has problems. It seems
that it contains workers in the map data - something that should not be
possible. I think this happened because I was working in an experimental branch
when I created the first version of this map. To fix this, try t
+1 :). I thought that the message boxes had this behaviour already (build in),
but it seems like they are no unique windows, so this will not work out the way
I hoped. So let's accept that there will be multiple dialogues possible.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13710
I tried that as well, but I can't avoid having multiple windows being
generated, which is behaviour you pointed out that we don't want. So, not
making it unique implies the current behaviour. So, I need a +1 on that before
I change the code again.
--
https://code.launchpad.net/~widelands-dev/wi
Or just do not bother with making the dialogue unique in the first place. As
mentioned, all dialogues seem to be non unique in Widelands right now. If we
change that, we should change it for all dialogues at the same time.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+mer
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1380307/+merge/238083
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1380307.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
oops, it is there. I was looking on wrong branch...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1371062.
___
Mailing list: https
What about confirmation dialog when exiting Multiplayer (LAN/Direct IP) game?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1371062.
_
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1380307 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1380307/+merge/238083
Very simple fix.
The function is not used now, an
OK, after a couple of hours of fiddling and trying all kinds of things from
disabling the Exit button to using a unique_ptr, I am left with the following
options:
- Try to understand the whole ActionWindow control flow (tried before and
failed, but a second look can never hurt)
- Implement a U
The problem is with the test suite. I can't track it down, so it probably lies
with the binaries somewhere. I decided to allow lower packet versions in some
places to keep the tests working, and there was no change in the packet
content, just the packet number. I don't know how to fix the binari
Lgtm
--
https://code.launchpad.net/~hjd/widelands/remove-indentation-checker/+merge/238075
Your team Widelands Developers is requested to review the proposed merge of
lp:~hjd/widelands/remove-indentation-checker into lp:widelands.
___
Mailing list: htt
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/remove-indentation-checker into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/remove-indentation-checker/+merge/238075
Removes an old python sc
The proposal to merge lp:~widelands-dev/widelands/bug-1378801 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1378801/+merge/237599
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13
No worries, I found it fast enough :)
Will merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1378801/+merge/237599
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1378801.
___
Mailing list: https:/
Review: Needs Fixing
Code looks good (I fixed some nits around, nothing major). the friend
declaration was not necessary, so I removed it.
it doesn't quite work on my system:
- exit shows the dialogue, ctrl exit quits immediately. this is working as
intended.
- the dialogues buttons also do the
Review: Approve
> SirVer doesn't have time to wait for the compiler when doing code reviews,
that is a poor excuse :(. Sorry for that.
Code lgtm now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1378801/+merge/237599
Your team Widelands Developers is subscribed to branch
lp:~wid
20 matches
Mail list logo
