* Source Package: widelands
* Version: 1:18-ppa0-bzr7265-201411220801~ubuntu14.04.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 12 minutes
* Build Log:
* Source Package: widelands
* Version: 1:18-ppa0-bzr7265-201411220801~ubuntu15.04.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 14 minutes
* Build Log:
* Source Package: widelands
* Version: 1:18-ppa0-bzr7265-201411220801~ubuntu14.10.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 16 minutes
* Build Log:
the problem is that we load the editor to fast these days 8).
We used to have ‘hints’ there, but they can hardly be read anymore. We could
something like “tipps of the week” when opening the editor, but they usually
are obnoxious. Best we finally get the help system underway.
On 21.11.2014,
Review: Needs Fixing
draw_overlay needs to know if it's drawing for the editor or for a game/replay.
I don't know how the control flow is here and what is accessible from the
function; you might need to add a function parameter.
Some more comments in the diff.
Diff comments:
=== modified
SirVer has proposed merging lp:~widelands-dev/widelands/remove_caching_in_ui
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_caching_in_ui/+merge/242559
In preparation of removing the
SirVer has proposed merging
lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
Removes alt
Review: Needs Fixing
That is not a proper fix. Assume this order of action:
- you set 10 fish on water.
- you switch the terrain to be greenland. Now you have 10 fish on greenland and
the map is broken.
- you now click the reduce resource tool - you now have 9 fish on water, but
that is still
Review: Approve
LGTM, will merge.
--
https://code.launchpad.net/~widelands-dev/widelands/remove_caching_in_ui/+merge/242559
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/remove_caching_in_ui.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/remove_caching_in_ui into
lp:widelands has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_caching_in_ui/+merge/242559
--
Your team Widelands Developers is
The proposal to merge lp:~widelands-dev/widelands/remove_alt_panning_of_window
into lp:widelands has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
--
Your team Widelands
SirVer has proposed merging lp:~widelands-dev/widelands/ui_fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
- Uses SDLK_ (logical keycodes) instead of
I will have to look at this in detail later, my brain's not working properly
today.
Codecheck still comes up with an error, could you please always run codecheck
over the complete code base before submitting a merge request? This way, we
won't have cosmetic changes in the diff in the future.
LGTM. 2 issues though:
1. Don't forget to remove the text conflict in src/ui_basic/panel.h
2. Alt switches the tool, but clicking doesn't do anything. I assume it's the
Ubuntu window manager getting in the way.
--
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
Your
The proposal to merge lp:~widelands-dev/widelands/ui_fixes into lp:widelands
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
--
Your team Widelands Developers is requested to review the
On very big maps using really low resolution, the minimap can get bigger than
the screen, so you wont be able to move it without alt dragging (on 800x600,
you need to the minimap of a 512x512 map to trigger the problem). But I am not
sure if we should really care about it, such low-resolution
didn't realise this is already merged, uncomitting isn't worth it.
--
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
Your team Widelands Developers is requested to review the proposed merge of
valid comment, however we have to deal with this in another fashion anyways.
Tablets do not have an ALT key.
--
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
Your team Widelands Developers is requested to review the proposed merge of
1. remerged trunk and fixed all conflicts.
2. that is probably an issue with the window manager. It works for me. I think
we should rethink the alternate tools (maybe left/right mouse buttons).
going to merge.
--
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
Your
The proposal to merge lp:~widelands-dev/widelands/ui_fixes into lp:widelands
has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
--
Your team Widelands Developers is requested to review the proposed
Filed a bug report for the Alt problem:
https://bugs.launchpad.net/widelands/+bug/1395322
--
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ui_fixes into
SirVer has proposed merging lp:~widelands-dev/widelands/save_minimap into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/save_minimap/+merge/242567
Saves a minimap into the folder of the map.
Review: Approve
LGTM, will merge
--
https://code.launchpad.net/~widelands-dev/widelands/save_minimap/+merge/242567
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/save_minimap.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/save_minimap into
lp:widelands has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/save_minimap/+merge/242567
--
Your team Widelands Developers is subscribed to branch
Running clang-format is good :) Doesn't work on my system though :(
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/seafaring-ai into lp:widelands.
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/section-initialization into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/section-initialization/+merge/242577
Found by scan-build.
--
Your
26 matches
Mail list logo
