My terminal doesn't seem to know pushd/popd, so I have added some tests with ls
| grep.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1219914/+merge/242772
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1219914.
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/texture_atlas/+merge/243119
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/texture_atlas.
___
Mailing list:
Maybe we could override f with do nothing in FullscreenMenuBase, until we can
fix this up? Better no functionality than something that will be perceived as
buggy by the user.
--
https://code.launchpad.net/~widelands-dev/widelands/f_for_fullscreen/+merge/243227
Your team Widelands Developers is
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/use_sdl_image_in_one_place/+merge/243120
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/texture_atlas.
___
Mailing list:
//ref_castConstructionSite const, Building
const(b).building().name().c_str());
dynamic_castconst ConstructionSite((b).building().name().c_str()));
commented out is before, the second one is what I want to use. Before it used
to compile, now it complains:
defaultai.cc:3766:48: error:
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/use-bundled-fonts
into lp:~widelands-dev/widelands/debian.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #973714 in widelands: fonts are different between daily ppa and bzr
repository
@SirVer - I changed the test as you asked
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1281823/+merge/242837
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1281823.
___
Mailing list:
great. only the rename from starting_ to initial_ and this is good to go.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1281823/+merge/242837
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1281823.
Review: Approve
lgtm. lots of deletes which always means simpler code :)
--
https://code.launchpad.net/~hjd/widelands/use-bundled-fonts/+merge/243323
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/debian.
___
other branch, definitively. this change already got bigger than i wanted it to
be and I also want to ships this asap.
--
https://code.launchpad.net/~widelands-dev/widelands/cleanup_game_renderer/+merge/243124
Your team Widelands Developers is requested to review the proposed merge of
The proposal to merge lp:~widelands-dev/widelands/use_sdl_image_in_one_place
into lp:widelands has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/use_sdl_image_in_one_place/+merge/243120
--
Your team Widelands
What you are suggesting is the status quo (just refactored). I set out to solve
the particular use case mentioned in bug 682351, mainly that you need to start
a game to leave fullscreen. This use case is supported now, you can exit
fullscreen, look something up and then enter fullscreen again
Review: Needs Fixing
Diff comments:
=== added file 'utils/merge_and_push_translations.sh'
--- utils/merge_and_push_translations.sh 1970-01-01 00:00:00 +
+++ utils/merge_and_push_translations.sh 2014-12-01 09:36:12 +
@@ -0,0 +1,61 @@
+## This script will fix translations
renaming done. I did recursive renaming with sed so quite a lot files has been
changed.
BTW: look at the 'Description of the Change' now, funny :) Or terrible overhead
I can say :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1281823/+merge/242837
Your team Widelands Developers
Review: Needs Fixing
You missed some :). See inline comments.
Diff comments:
=== modified file 'src/editor/map_generator.cc'
--- src/editor/map_generator.cc 2014-09-20 09:37:47 +
+++ src/editor/map_generator.cc 2014-12-01 21:50:51 +
@@ -138,7 +138,7 @@
Review: Needs Fixing
Okay, next round :). I think this converges..
Time for the next round. FontSet now has its own class and parses itself. The
singleton is gone - FontHandler1 now does the job.
That is much better. But the singleton is still raining on our parade with the
stand alone
16 matches
Mail list logo
