Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/smiley-and-codeblock-enhancements into lp:widelands-website

2015-01-08 Thread kaputtnik
Hoping i've done it the right way... Thank you for review and pointing on some mistakes. And for the hints to grep. -- https://code.launchpad.net/~franku/widelands-website/smiley-and-codeblock-enhancements/+merge/245742 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/smiley-and-codeblock-enhancements into lp:widelands-website

2015-01-08 Thread kaputtnik
Tanks for approve. Your changes look fine. Just one question and an answer to your question in the code below. Yes the #b's (appears twice) are unintendet, better: i forgot to remove them. I used them to trigger an error to debug the code. I haven't found a way to debug the code (make halt

Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/smiley-and-codeblock-enhancements into lp:widelands-website

2015-01-08 Thread SirVer
Review: Needs Fixing Is there a better way? A hint on that is welcome :-) printf debugging is what I use most of the times too - pdb is not a great debugger. however I have a snippet in my editor that will format all lines I output like so: print #sirver: a: %s % a. Similarly if i note

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

2015-01-08 Thread SirVer
I think these tests should be done for all players - what you describe can happen for a human player too if he presses the same button twice while the command is still distributed to other players in the game. Can easily happen in slow network games. Your code saveguards against that and should