Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

2015-01-30 Thread TiborB
of course I tested only AI-only games, because I dont have enough time for a real game... -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-ai.

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/unused-option into lp:~widelands-dev/widelands/debian

2015-01-30 Thread GunChleoc
Review: Approve The parameter rings a bell. LGTM. -- https://code.launchpad.net/~hjd/widelands/unused-option/+merge/248152 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/debian. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

2015-01-30 Thread TiborB
@GunChleoc first NOCOM is perhaps a mistake?? and second one was discussed with SirVer and I think this is no problem and I might remove it. But I will wait for another review and comments -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271 Your team Widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1374831 into lp:widelands

2015-01-30 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1374831 into lp:widelands has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1374831/+merge/248092 -- Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

2015-01-30 Thread GunChleoc
My testing was done to see if anything crashes, and to check if behaviour is OK. I think it is OK for now - I just decided to give detailed feedback so we know what can be improved further. Once the 2 remaining NOCOMS are fixed, I think this branch is ready to be merged :) --