Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/devs_and_locales_list into lp:widelands-website

After running pyformat over the file there some changes to old code also. I run a last test of the file and all is good. So i think it's ready to merge. Thanks for you hints :-) -- https://code.launchpad.net/~franku/widelands-website/devs_and_locales_list/+merge/266025 Your team Widelands Develo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-653308 into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/bug-653308 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-653308/+merge/265931 -- Your team Widelands Developers is subscribed to branch lp:~

Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/devs_and_locales_list into lp:widelands-website

Since you also approved the Widelands-part, whenever kaputtnik says he is happy with his code now :) Then, we will need the coordinated merging and website deployment like you did last time. -- https://code.launchpad.net/~franku/widelands-website/devs_and_locales_list/+merge/266025 Your team Wi

Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/devs_and_locales_list into lp:widelands-website

Review: Approve Code looks good. When should I merge this? -- https://code.launchpad.net/~franku/widelands-website/devs_and_locales_list/+merge/266025 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https:

Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/devs_and_locales_list into lp:widelands-website

I personally always run pyformat[1] over the code. It changes the ticks to be consistent. Unfortunately, PEP8 is remarkably ugly, but that is what the python folks like. [1] https://pypi.python.org/pypi/pyformat -- https://code.launchpad.net/~franku/widelands-website/devs_and_locales_list/+merg

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1375579 into lp:widelands

Review: Approve the nocom needs to stay, otherwise lgtm. Diff comments: > === modified file 'src/graphic/gl/system_headers.h' > --- src/graphic/gl/system_headers.h 2015-03-01 09:21:20 + > +++ src/graphic/gl/system_headers.h 2015-07-28 07:15:08 + > @@ -38,6 +38,7 @@ > #ifdef USE_GLBI

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/authors_and_languages into lp:widelands

Review: Approve -- https://code.launchpad.net/~widelands-dev/widelands/authors_and_languages/+merge/265892 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/authors_and_languages. ___ Mailing list: https://launchpad.n

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-653308 into lp:widelands

Review: Approve -- https://code.launchpad.net/~widelands-dev/widelands/bug-653308/+merge/265931 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-653308. ___ Mailing list: https://launchpad.net/~widelands-dev Post

Re: [Widelands-dev] [Merge] lp:~franku/widelands-website/devs_and_locales_list into lp:widelands-website

Code still LGTM :) -- https://code.launchpad.net/~franku/widelands-website/devs_and_locales_list/+merge/266025 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/trainingsites_and_teams into lp:widelands

Yes, it took me too long to find the time for a review :( -- https://code.launchpad.net/~widelands-dev/widelands/trainingsites_and_teams/+merge/260517 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/trainingsites_and_teams. _