Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_persistent_data into lp:widelands

2015-10-16 Thread TiborB
Thanks for review, I will incorporate comments (most of them at least :)). See also my comments to your comments in the diff. Diff comments: > > === modified file 'src/ai/defaultai.cc' > --- src/ai/defaultai.cc 2015-08-28 19:09:59 + > +++ src/ai/defaultai.cc 2015-10-05 17:29:41

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1506084 into lp:widelands

2015-10-16 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1506084 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1506084 in widelands: "Regressiontest failing" https://bugs.launchpad.net/widelands/+bug/1506084 For more details, see: https://

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_persistent_data into lp:widelands

2015-10-16 Thread GunChleoc
I can't say anything about how good the heuristics are, but I have added some code style comments / ideas. Diff comments: > === modified file 'src/ai/ai_help_structs.h' > --- src/ai/ai_help_structs.h 2015-08-19 19:29:56 + > +++ src/ai/ai_help_structs.h 2015-10-05 17:29:41 + > @@ -303,7