[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1542238-log into lp:widelands

2016-02-05 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1542238-log into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1542238 in widelands: "assertion failed within unset_position()" https://bugs.launchpad.net/widelands/+bug/1542238 For more

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/simplify_setbobdescription into lp:widelands

2016-02-05 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/simplify_setbobdescription into lp:widelands. Commit message: Remove support in setbobdescription for tribe bobs. There aren't any. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1345741 in widelands: "Simpl

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_removal_of_ports into lp:widelands

2016-02-05 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/fix_removal_of_ports into lp:widelands. Commit message: Ports can be affected by terrain changes up to 3 tiles away from their original position, so we need to recalculate as much when changing a terrain tile. Requested reviews: Widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread Klaus Halfmann
WL crashed on me after I tried to open a games and iternet game I save some versions ago, Ill try a new game tomorrow unless this should work? -- https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517 Your team Widelands Developers is subscribed to branch lp:~w

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread Klaus Halfmann
Hello SirVer: Id like to move the 0.5 * line_width invariant in tesselate_line_strip out of the loop. (I tend to optimize all the code I see) -- Hasi50 > Am 05.02.2016 um 20:19 schrieb SirVer : > > If you want to play around a little bit more, go for it. I will not code > anymore tonight, so

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread SirVer
If you want to play around a little bit more, go for it. I will not code anymore tonight, so I will only clean this up tomorrow anyways. There are the parameters you can play with - In the last commit I removed the code that draws the circles to connect to lines, so lines are not connected anym

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/add_hint_to_map_info into lp:widelands

2016-02-05 Thread GunChleoc
Review: Approve LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/add_hint_to_map_info/+merge/285228 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/add_hint_to_map_info. ___ Mailing list: https://launch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/add_hint_to_map_info into lp:widelands

2016-02-05 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/add_hint_to_map_info into lp:widelands. Commit message: Add "hint" to the json file created by wl_map_info. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread GunChleoc
Sgrìobh SirVer na leanas 05/02/2016 aig 18:30: > You are a hard audience :). Fuzzy graphics make me physically ill, because I have some crossed wires in my brain, so I have to be ;) The last version is working for me. The seams aren't 100% perfect, but it's barely noticeable, so I think this can

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread SirVer
What I meant to say is that it is fully functional, just the source code contains NOCOMs still. -- https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/beautiful_correct_lines.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread SirVer
You are a hard audience :). I tried another shading approach - source is not cleaned up, but could you all give it another shot? -- https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/w

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread GunChleoc
Right-angles lines look better with alpha 30, but slanted lines look better with alpha 80 slanted lines with alpha 80 suffer from jaggies. https://en.wikipedia.org/wiki/Jaggies Is there a way to make the alpha dependent on the angle of the line? -- https://code.launchpad.net/~widelands-dev/wide

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1289943 into lp:widelands

2016-02-05 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1289943 into lp:widelands. Commit message: When a waresqueue disappears in a minimized constructionsite window, the contents no longer leak on screen. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #12

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread SirVer
That anti aliasing is intended. :). Maybe it is too strong. You ca tweak the value yourself. In surface function a second line is drawn with a lower alpha. Just try it out, maybe another value is better. > Am 05.02.2016 um 11:38 schrieb GunChleoc : > > Please don't jump off a bridge now, but

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread GunChleoc
Please don't jump off a bridge now, but I get some fuzzy lines now - the culprit seems to be interpolation of the edges with horizontal/vertical lines (0°, 90°, 180° and 270°). https://launchpadlibrarian.net/236372160/fuzzy_lines.png -- https://code.launchpad.net/~widelands-dev/widelands/beauti

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/beautiful_correct_lines into lp:widelands

2016-02-05 Thread kaputtnik
Review: Approve testing Fantastic :-) Really great job :-) https://bugs.launchpad.net/widelands/+bug/1531114/+attachment/4564387/+files/shot0002.png -- https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517 Your team Widelands Developers is subscribed to bran

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_ware_amount into lp:widelands

2016-02-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fix_ware_amount into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix_ware_amount/+merge/285099 -- Your team Widelands Developers is subscribed to br

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_ware_amount into lp:widelands

2016-02-05 Thread SirVer
no, not that important. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fix_ware_amount/+merge/285099 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_ware_amount. ___ Mailing list: https:/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_ware_amount into lp:widelands

2016-02-05 Thread GunChleoc
Diff comments: > === modified file 'src/logic/map_objects/tribes/bill_of_materials.h' > --- src/logic/map_objects/tribes/bill_of_materials.h 2015-12-11 19:06:50 > + > +++ src/logic/map_objects/tribes/bill_of_materials.h 2016-02-04 17:53:17 > + > @@ -25,7 +25,7 @@ > #include "logic/w

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/messagebox into lp:widelands

2016-02-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/messagebox into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/messagebox/+merge/285023 -- Your team Widelands Developers is subscribed to branch lp:~

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/messagebox into lp:widelands

2016-02-05 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/messagebox/+merge/285023 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/messagebox. ___ Mailing list: https://launchpad.net/~widelands-dev Post t

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1541697 into lp:widelands

2016-02-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1541697 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1541697/+merge/285054 -- Your team Widelands Developers is subscribed to branch lp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/messagebox into lp:widelands

2016-02-05 Thread SirVer
Review: Approve Add a tracking bug for the Ok/Cancel button placement? One nit, otherwise lgtm. Diff comments: > === modified file 'src/ui_basic/messagebox.cc' > --- src/ui_basic/messagebox.cc2016-01-28 05:24:34 + > +++ src/ui_basic/messagebox.cc2016-02-04 09:08:39 + >

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/pretty-datadirs into lp:widelands

2016-02-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/pretty-datadirs into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/pretty-datadirs/+merge/285086 -- Your team Widelands Developers is subscribed to br

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1541697 into lp:widelands

2016-02-05 Thread SirVer
Review: Approve @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1541697/+merge/285054 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1541697. ___ Mailing list: https://launchpad.net/~w