Failure is fixed in trunk?
So, this can go in.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-base-economy/+merge/285289
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395278-base-economy.
The proposal to merge lp:~widelands-dev/widelands/bug-1395278-map_objects into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-map_objects/+merge/285290
--
Your team Widelands Developers is
Continuous integration builds have changed state:
Travis build 623. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/107676245.
Appveyor build 480. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_b
The travis issues for 4.7 are fixed in trunk, all other version pass, so I
think this can go in.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-map_objects/+merge/285290
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-13
Continuous integration builds have changed state:
Travis build 622. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/107609019.
Appveyor build 479. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_m
Tested on this PPA:
https://code.launchpad.net/~sirver/+archive/ubuntu/widelands-daily/
--
https://code.launchpad.net/~widelands-dev/widelands/ppa_glbinding/+merge/285302
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ppa_glbinding into lp
SirVer has proposed merging lp:~widelands-dev/widelands/ppa_glbinding into
lp:widelands.
Commit message:
Change the PPA to build against the glbinding PPA so that we can get debug
traces from OpenGL.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.
Continuous integration builds have changed state:
Travis build 616. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/107568619.
Appveyor build 473. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_editor_help-4
The proposal to merge
lp:~widelands-dev/widelands/building-statistics-window-labels into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/building-statistics-window-labels/+merge/285292
--
Your team Wid
Thanks :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/building-statistics-window-labels/+merge/285292
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/building-statistics-window-labels.
___
Review: Approve testing
Works also for me.
--
https://code.launchpad.net/~widelands-dev/widelands/building-statistics-window-labels/+merge/285292
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/building-statistics-window-labels.
___
The proposal to merge lp:~widelands-dev/widelands/bug-1542214 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1542214/+merge/285260
--
Your team Widelands Developers is subscribed to branch
lp
Review: Approve code & testing
Bug is fixed for me. I fixed some nits during code review, ptal and merge if
happy.
--
https://code.launchpad.net/~widelands-dev/widelands/building-statistics-window-labels/+merge/285292
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wide
Review: Approve code
skimmed the code, did not see anything wrong. Once travis is happy, this can go
in.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-map_objects/+merge/285290
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395278-ma
Review: Approve
Thanks for championing the RTL support in Widelands, that is awesome.
code lgtm.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1542214/+merge/285260
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1542214.
__
GunChleoc has proposed merging
lp:~widelands-dev/widelands/building-statistics-window-labels into lp:widelands.
Commit message:
Fixes/Improvements to Building Statistics:
- The labels below the buttons are now properly center-aligned
- The text size of the labels below the buttons is now calculat
Review: Needs Fixing
Finished code review. I have some reservation about the API design in the Lua
part. I think we should not rely on passing around so many strings, instead
pass around the structured objects already.
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1395278-map_objects into lp:widelands.
Commit message:
Fixed member variables in src/logic/map_objects, but not in its subdirectories.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.lau
Thanks!
I'll wait until you're done with the .cc files, so we won't be both playing
with the branch at the same time.
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/editor_help.
I started reviewing this now, I got through all the Lua files and fixed a
couple of nits and left NCOMs (accidentally some with my username, but they are
all yours :)).
I hope to get around to the .cc files later.
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/28390
Review: Approve code / compile
Compiles for me,
Manual Review in launchapd was fine,
will play on this branch for some time now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-base-economy/+merge/285289
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/
The proposal to merge lp:~widelands-dev/widelands/dedicated_out_of_main into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/dedicated_out_of_main/+merge/285268
--
Your team Widelands Developers is subs
The proposal to merge lp:~widelands-dev/widelands/different_replay_names into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/different_replay_names/+merge/285265
--
Your team Widelands Developers is re
The proposal to merge lp:~widelands-dev/widelands/parent_directory into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/parent_directory/+merge/285276
--
Your team Widelands Developers is subscribed to
Review: Approve
Compiles, does work fine. No regressionson windows found.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/dedicated_out_of_main/+merge/285268
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/dedicated_out_of_main.
___
The proposal to merge
lp:~widelands-dev/widelands/do_not_update_size_when_minimized into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/do_not_update_size_when_minimized/+merge/285277
--
Your team Wid
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/do_not_update_size_when_minimized/+merge/285277
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/do_not_update_size_when_minimized.
___
Mailing lis
Thanks for cleaning up after me.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/parent_directory/+merge/285276
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/parent_directory.
___
Mailing lis
// NOCOM why was this deleted? if (!complete) throw wexception("Out of memory");
because it is rather pointless. We allocate memory everywhere and never check
for OOM errors. One of the reasons is that if the OS does not have any more
memory to give you, it will not give you any memory for creat
The proposal to merge lp:~widelands-dev/widelands/bug-1542238-log into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1542238-log/+merge/285237
--
Your team Widelands Developers is subscribed to br
30 matches
Mail list logo
