Continuous integration builds have changed state:
Travis build 875. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/117286050.
Appveyor build 708. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1422347_
I am 99% sure that this cannot change semantics in Lua. Are all other
possibilities like flakiness, timing, map locations explored?
> Am 21.03.2016 um 06:02 schrieb GunChleoc :
>
> The rest of the script was running fine. The fix happened by accident.
> --
> https://code.launchpad.net/~wideland
The rest of the script was running fine. The fix happened by accident.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1540813-island-hopping
I agree the labels could be improved.
I don't like "Transport mode" - too techy.
For "Unloading", I used to have "Building Port", but I didn't like that either,
because as soon as the wares and builder are unloaded, the ship goes into
transport mode while the port is building - how about "Found
Continuous integration builds have changed state:
Travis build 873. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/117270666.
Appveyor build 706. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1540813_i
Also one small question in diff
Diff comments:
>
> === modified file 'src/logic/map_objects/tribes/building.cc'
> --- src/logic/map_objects/tribes/building.cc 2016-03-10 12:40:49 +
> +++ src/logic/map_objects/tribes/building.cc 2016-03-19 18:56:25 +
> @@ -664,38 +661,26 @@
> Draw
Nice :)
Maybe two small comments
"Transporting Wares" - sometimes a ship only waits, so the term is perhaps not
optimal, what about "transport mode"
"Unloading" - also bit misleading, is suggest it is transportation mode and
just arrived in port and unloading wares. Right now I have no idea w
Also, what made you even attempt such a strange fix? Have you experienced a
similar issue before?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/wideland
Was the script running at all (e.g. did you receive the initial welcome
message)? Any error messages?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/wide
On my machine, I couldn't get it to hop at all without the blank spaces.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1540813-island-hoppi
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1422347-no-scenario-replays into lp:widelands.
Commit message:
Stop writing replays for scenarios. Fixed "Scenario" localization for loadgame.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1422347 in
The proposal to merge lp:~widelands-dev/widelands/watchwindow-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
--
Your team Widelands Developers is subscribed t
Am I missing something? How did adding these two spaces fix the bug? There
should be no difference.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widela
Cool, thanks for testing and fixing! Travis went through as well.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/watchwindow-fixes.
Review: Approve test / compile
Bug #1553699? is fixed with this branch,
just reproduced this on bzr7903[trunk],
and found it fixed it here in bzr7904[watchwindow-fixes]
@Miroslav Remák: thanks for fixing this.
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/2895
@Klaus Halfmann
Also, did you notice the reproduction steps I posted in bug #1553699? Can you
try these steps with the version used in the bug report (bzr7866) to see if
they produce a crash and if so, try the same steps with this branch?
--
https://code.launchpad.net/~widelands-dev/widelands/wa
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1556621-win-condition-translations/+merge/289019
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1556621-win-condition-translations.
___
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands.
Commit message:
Fixed the hopping in the Island Hopping scenario.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1540813 in widelands: "Island Hopping: Hopping
> I am still missing some comments about the basic
> workings of this (very sepcial) window. and I have some questions:
>
> * why is uint8_t as index, a plain unsigned int would not make a difference?
Old code. We actually think that using int is even better than unsigned int,
because it prevent
I am still missing some comments about the basic
workings of this (very sepcial) window. and I have some questions:
* why is uint8_t as index, a plain unsigned int would not make a difference?
* why is there no visual response when adding the last view fails?
I cannot reproduce #1553699 directly
New changes still LGTM - Happy :)
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/watchwindow-fixes.
___
Mailing list: https://lau
Review: Approve
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/new_workarea_pics/+merge/289578
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/new_workarea_pics.
___
Mailing list: https://laun
The proposal to merge lp:~widelands-dev/widelands/new_workarea_pics into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/new_workarea_pics/+merge/289578
--
Your team Widelands Developers is subscribed t
The proposal to merge
lp:~widelands-dev/widelands/bug-1556621-win-condition-translations into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1556621-win-condition-translations/+merge/289019
--
You
Do you mean on the bottom of debug window? I noticed this as well. But it has
nothing to do with this change
--
https://code.launchpad.net/~widelands-dev/widelands/ship_DBG_window/+merge/289110
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ship_DBG_window
kaputtnik has proposed merging lp:~widelands-dev/widelands/new_workarea_pics
into lp:widelands.
Commit message:
Better coloring for workarea pics.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #536473 in widelands: "Improve working area preview"
https://bugs.lau
The proposal to merge lp:~widelands-dev/widelands/new_workarea_pics into
lp:widelands has been updated.
Commit Message changed to:
Better coloring for workarea pics.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/new_workarea_pics/+merge/289578
--
Your team Wideland
Ill try to reproduce #1553699 whit this perhaps today ...
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/watchwindow-fixes.
___
M
Review: Approve
LGTM :)
I think it would also be great when a new location is added, that the window
activates that new location. It doesn't do that in trunk either though, so it's
up to you if you want to work on this in this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/watc
Continuous integration builds have changed state:
Travis build 867. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/117151949.
Appveyor build 702. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_show_ship_na
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1395278-editor
into lp:widelands.
Commit message:
Refactored member variable names in src/editor.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1395278 in widelands: "Consolidate naming of member vari
Review: Approve
Found only intended renamings or improvements,
Added some comments about minor things.
New for me are warnings like:
[ 44%] Building CXX object
src/logic/CMakeFiles/logic.dir/map_objects/tribes/requirements.cc.o
.../bug-1395278-editor/src/logic/map_objects/tribes/requirements.cc:
32 matches
Mail list logo
