Review: Needs Fixing
During compiling i got some hints about too long lines.
On first run i choosed "Editor" and pressing the Help button the editor
segfaults:
*** Error in `./widelands': double free or corruption (!prev):
0x0452cfc0 ***
A Backtrace from widelands (not gdb) could be
The proposal to merge
lp:~widelands-dev/widelands/bug-1252625-statistics-window-update into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1252625-statistics-window-update/+merge/289569
--
Your
Thanks! When you have some time, could you have a look at the "About" branch
too? It has already been tested.
I am thinking of creating a new text domain for the editor help, I might still
do that in the other branch.
--
Thanks! I'd still like somebody to test, to make sure that I haven't missed
anything.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1422347-no-scenario-replays/+merge/289582
Your team Widelands Developers is subscribed to branch
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1252625-statistics-window-update/+merge/289569
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1252625-statistics-window-update.
___
Review: Approve
OK, let's wait for somebody else to come in and do some more testing - you have
my approval for the code (my "Abstain" was a misclick).
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830
Your team Widelands Developers is subscribed to branch
Review: Approve
Looks nice, though I am not able to understand all the code; also I see you
added regression tests - great
Anyway, somebody should compile and test it...
Approving the code
--
https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782
Your team
Review: Approve
Code LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1252625-statistics-window-update/+merge/289569
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1252625-statistics-window-update.
Review: Approve
Code LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1422347-no-scenario-replays/+merge/289582
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1422347-no-scenario-replays.
___
This change is mostly relevant for peoples who tend to micromanage everything
and somebody like that should review and comment this. Also we can further
modify the log's content, but somebody should say what is he/she missing
there
--
Review: Abstain
I have streamlined the code a bit, that shouldn't change the semantics.
Code looks clean, and soldiers seem to be retreating properly.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830
Your team Widelands Developers is subscribed to branch
11 matches
Mail list logo
