kaputtnik has proposed merging
lp:~widelands-dev/widelands/bug_1566720_set_origin into lp:widelands.
Commit message:
Fix miscalculation of map->get_width() and map->get_height() regarding
coordinates.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1566720 in wide
> The Tooltips make such help nearly superfluous :-)
Exactly my point - it's there with the tooltips, and the less the user has to
read and memorize, the better IMO.
> The only thing i am wondering is the tooltip for "Noise height -> Set Value"
> which says "Use Shift + Click or Ctrl + Click ..
Continuous integration builds have changed state:
Travis build 975. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/121219958.
Appveyor build 808. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395322_
Continuous integration builds have changed state:
Travis build 974. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/121219787.
Appveyor build 807. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_string_fixes
Removing the additional headers for "Height and Resources tool" and "Noise
height tool" in the help doesn't fit my taste. A general help should be driven
by "Information as clear as it could be", not "Information as short it could
be". But if you think it's good, lets leave it. The Tooltips make
Continuous integration builds have changed state:
Travis build 939. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/120306796.
Appveyor build 772. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_string_fixe
The proposal to merge lp:~widelands-dev/widelands/bug-1395322-tool3 into
lp:widelands has been updated.
Commit Message changed to:
Added CTRL as selection key for the 2nd alternative tool and updated help text.
Redesigned the Height, Noise and Resources tools to use proper SpinBoxes and
Boxes.
The proposal to merge lp:~widelands-dev/widelands/bug-1395322-tool3 into
lp:widelands has been updated.
Commit Message changed to:
Added CTRL as selection key for the 2nd alternative tool and updated help text.
Redesigned the Heigh, Noise and Resources tools to use proper SpinBoxes and
Boxes.
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Commit message:
Fixed string issues in Dolomites and worker help.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "Black" and "Wastela
Review: Resubmit
And another scope creep... since the tooltips wouldn't take, I redesigned the
Heigh, Noise and Resources tools to use proper SpinBoxes and Boxes.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed t
Sounds good.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395322-tool3.
___
Mailing list: https://launchpad.net/~widelands
Ok, then it would be fine if the CTRL + Click for Portdocks get changed in this
branch :-)
And removing the shift key from:
"Shift or Ctrl + Click : Set height to the value selected by ‘Set Value’"
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team
This is a problem only in Windows, it performs fine on Linux and Mac.
I put the merge request on hold, because I gave up trying to fix this. We
should keep the branch though - hopefully, a Windows dev will be able to take
this on, and then they can see what I have already tried. This way, they w
Sounds like this bug:
https://bugs.launchpad.net/widelands/+bug/1535065
And I thought I had it fixed.
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/rename_editor_files.
Mhh, looks like _setting_ the playerpos succeed but nrplayers is inconsistant,
mmh.
Should be unrelated to this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/rena
Ah, here is the assertion:
WARNING: Player 1 has no starting position - illegal coordinates (29508, 22202).
WARNING: Player 2 has no starting position - illegal coordinates (-1, -1).
WARNING: Player 1 has no starting position - illegal coordinates (29508, 22202).
WARNING: Player 2 has no starting
perhaps to fast: /
Got a Crash in creating a radom Map 80x80 for 3 players in
Widelands::Map::get_starting_pos(unsigned char) const + 130 (map.h:205)
editor_tool_set_starting_pos_callback(Widelands::TCoords
const&,
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merg
The proposal to merge lp:~widelands-dev/widelands/rename_editor_files into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093
--
Your team Widelands Developers is subscrib
I don't think that we should go to the trouble to remove the fallbacks - it
would only add code. We document the intended keys, and if additional keys work
too, I don't see a problem. Basically, if there is no third option, the
behavour of the Ctrl key is undefined, so it doesn't matter if it sw
That was fast, thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/rename_editor_files.
___
Mailing list: h
Review: Approve
OK, found only the expected renamings.
OK, Compiles on OSX
I have seen no actual code changes -> Approve
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/r
GunChleoc has proposed merging lp:~widelands-dev/widelands/rename_editor_files
into lp:widelands.
Commit message:
Removed "editor_" prefix from editor source files.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelan
It's used as a fallback to the first alternative version of the tool if the
second one is not available. It makes sense to me, but I'm not against changing
this behavior.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subs
23 matches
Mail list logo
