The proposal to merge lp:~widelands-dev/widelands/bug_1566720_set_origin into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug_1566720_set_origin/+merge/291207
--
Your team Widelands Developers is su
Review: Resubmit
Ok, please have another look on linux.
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/python3.
___
Mailing list: https://
Review: Approve
LGTM. All other uses of map->get_width() seem to be OK. This was a classic
indexing error.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug_1566720_set_origin/+merge/291207
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widela
The highest Lua version available on my system is 5.2. Ubuntu introduced Lua
with version 15.04, but I usually only use long term releases, which means that
I will have to wait until 16.04 comes out in order to switch to Lua 5.3.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001
Continuous integration builds have changed state:
Travis build 980. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/121409569.
Appveyor build 813. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_python3-813
Continuous integration builds have changed state:
Travis build 978. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/121359254.
Appveyor build 811. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1566720_
We're going to break savegame compatibility for this release anyway. What's
holding us from updating to Lua 5.3 eris?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-de
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1543001-eris
into lp:widelands.
Commit message:
Updated Eris to version 1.1.0.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1543001 in widelands: "Update Eris for build 19"
https://bugs.launchpad.n
The proposal to merge lp:~widelands-dev/widelands/bug-1395322-tool3 into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
--
Your team Widelands Developers is subscribed t
Thanks for testing & review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395322-tool3.
___
Mailing lis
On my system. this will start the Widelands main screen for each test instead
of going to the scenario. Python 2.7
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/python3.
___
Review: Needs Fixing
Hm, I did run the test with both Python 2/3 without these errors, but perhaps I
aborted them too early.
Or the test do not currently run on windows?
I'll check this later today...
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelan
Mhh, even using python 2.7 does not work, it just gets stuck in the splasg
screeen?
Was there some change in the Lua Binding?
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev
OK, thas as far as I came, too but now I get
$ ./regression_test.py -b ./widelands
...
File "./regression_test.py", line 103, in run_widelands
stdout_file.write(line)
TypeError: must be str, not bytes
I used
print(line, flush=True)
for
stdout_file.write(line)
stdout_file.flush()
but
Looks like you know more about python than I do,
lets check this ...
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/python3 into lp:widelands.
___
Tino has proposed merging lp:~widelands-dev/widelands/python3 into lp:widelands.
Commit message:
Add a compatibility layer to regression_test.py to allow running with python 2
and 3
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1566876 in widelands: "regression_t
The proposal to merge lp:~widelands-dev/widelands/python3 into lp:widelands has
been updated.
Commit Message changed to:
Add a compatibility layer to regression_test.py to allow running with python 2
and 3
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/python3/+merg
See diff comments, otherwise LGTM.
Diff comments:
>
> === modified file 'src/editor/ui_menus/tool_change_height_options_menu.h'
> --- src/editor/ui_menus/tool_change_height_options_menu.h 2016-04-06
> 09:23:04 +
> +++ src/editor/ui_menus/tool_change_height_options_menu.h 2016-04-07
The proposal to merge lp:~widelands-dev/widelands/string-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/291154
--
Your team Widelands Developers is subscribed to branch
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/291154
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
Review: Approve
LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/291154
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://launchpad.net/~widelands
Review: Approve testing
I think it's good to go now :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395322-tool3.
___
Ma
22 matches
Mail list logo
