[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-986611-cppcheck_performance into lp:widelands

2016-08-04 Thread bunnybot
Continuous integration builds have changed state: Travis build 1234. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149822460. Appveyor build 1076. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-986611-cppcheck_performance into lp:widelands

2016-08-04 Thread bunnybot
Continuous integration builds have changed state: Travis build 1234. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149822460. Appveyor build 1076. State: failed. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/cleanup_ggz into lp:widelands-website

2016-08-04 Thread kaputtnik
Regarding your code comment: I actually do not know how sending e-mails is processed on the server. A value for EMAIL_BACKEND isn't set there. So adding a comment like: "Disable this on the widelands server"? Or we make it dependent of the DEBUG value: if DEBUG = True: EMAIL_BACKEND =

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands

2016-08-04 Thread bunnybot
Continuous integration builds have changed state: Travis build 1231. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149798427. Appveyor build 1073. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands

2016-08-04 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: The read operation timed out -- https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1588063.

[Widelands-dev] [Build #10563219] i386 build of widelands 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 in ubuntu yakkety RELEASE [~widelands-dev/ubuntu/widelands-daily]

2016-08-04 Thread Launchpad Buildd System
* Source Package: widelands * Version: 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 * Architecture: i386 * Archive: ~widelands-dev/ubuntu/widelands-daily * Component: main * State: Failed to build * Duration: 49 minutes * Build Log:

[Widelands-dev] [Build #10563218] amd64 build of widelands 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 in ubuntu yakkety RELEASE [~widelands-dev/ubuntu/widelands-daily]

2016-08-04 Thread Launchpad Buildd System
* Source Package: widelands * Version: 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 * Architecture: amd64 * Archive: ~widelands-dev/ubuntu/widelands-daily * Component: main * State: Failed to build * Duration: 26 minutes * Build Log:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands

2016-08-04 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands

2016-08-04 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-final-objective. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands

2016-08-04 Thread GunChleoc
Do you see the o.done = true a few lines below the changed line? That marks the objective as done. However, the current objective was o2, so it was never marked as done. -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands

2016-08-04 Thread Klaus Halfmann
Review: Approve compile, play OK, finally it works. Now please tell me why that simple code change did this trick. Can I merge this wia launchpad now, or must someone else do this? -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 Your team Widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands

2016-08-04 Thread bunnybot
Continuous integration builds have changed state: Travis build 1229. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149710458. Appveyor build 1071. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands

2016-08-04 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1588063 into lp:widelands has been updated. Commit Message changed to: Fix automatic creation of the maps/My_Maps folder in Windows. Prevent the user from entering illegal filenames. For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands

2016-08-04 Thread GunChleoc
Yes, you need to start the tutorial from the beginning again - otherwise, the Lua script won't be loaded from scratch. Sorry for nor doing the trunk merge myself, I'm a bit snowed under at the moment. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/cleanup_ggz into lp:widelands-website

2016-08-04 Thread SirVer
Review: Approve the metaserver executes only these two queries: select password from wlggz_ggzauth where user_id=? select permissions from wlggz_ggzauth where user_id=? so your assessment is correct, only user_id, permissions and password are ever read. I'd vote for removing the fields -