Review: Resubmit
I found a failure due to a missing import in this branch and fixed it. The
culprit why i not stumbled over this the first time was a remaining fields.pyc
file which i haven't deleted when removing fields.py. So the missing import
doesn't show up in my local branch... lesson lea
* Source Package: widelands
* Version: 1:18-ppa0-bzr8052-201608051702~ubuntu16.10.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 25 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wid
* Source Package: widelands
* Version: 1:18-ppa0-bzr8052-201608051702~ubuntu16.10.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 21 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wi
Code llooks +/- equal for all tribes, lets do some testing.
--
https://code.launchpad.net/~7010622-q/widelands/topple-production-logic-2/+merge/301477
Your team Widelands Developers is requested to review the proposed merge of
lp:~7010622-q/widelands/topple-production-logic-2 into lp:widelands.
*happy* Thanks for testing, everyone!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1588063.
___
Mailing list: https://launchpad.n
The proposal to merge lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
--
Your team Widelands Developers is subscribed to branch
lp
Review: Approve
Nice, thanks Gun.
I can compile fine and do not find those bugs active any longer.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1588063.
_
Review: Resubmit
I have decided to only filter out the characters that can lead to potential
crashes, not the "inconvenient" ones that look confusing on the command line
(like e.g. $).
I have tested on Windows and all should be fine now - both bugs fixed.
--
https://code.launchpad.net/~widelan
Review: Approve compile, review, test
OK, Tested some "evil" charaters. On OSX '`ยด&$()[]{} are allowed while |/":*
are not (incomplete).
Maybe we should filter these as well, to avoid Filenames with bad effects on
the Commandline?
OTOH the average user will not not use such characters, will he/
Continuous integration builds have changed state:
Travis build 1236. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/149854580.
Appveyor build 1078. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_158806
10 matches
Mail list logo
