Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread toptopple
@Tibor The solution currently implemented leads to retardment of exploration; ships over and over again explore the already explored islands. This is something AI cannot afford on larger maps with many and/or far away islands, it already harbours a tendency to be very late with sea expeditions.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-11 Thread GunChleoc
Yep, I liked the beer too - it's a balancing thing tough. 2) A flag sounds good. The reason for the inconsistency is that until now, this was used to fill working positions, where allowing higher ranking workers is important. 3) It can be resolved like this: bool found = false; for (co

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread GunChleoc
@Tibor: no worries, you don't have to. Your advice will get us there :) -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the proposed merge of lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands. __

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: Running 'git pull' failed. Output: fatal: No remote repository specified. Please, specify either a URL or a remote name from which new revisions should be fetched. -- https://code.launchpad.net/~7010622-q/widelands/topple-seaf

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread TiborB
@Gun I am not that eager to work on this now :(, but I am willing to support toptopple :) re: "You can aid the reformation by adding another call to "expedition_management()" in the case where both holds true: a) ship sails in modus "circle island", b) ship hits a spot which has been noted as "

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread GunChleoc
toptopple, if you change the branch owner ("Change branch Details" link on the top left) wo widelands-dev, you can both work on the branch together :) -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the prop

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread TiborB
iterating over existing portspaces makes sense, because: - the ship does not pick first portspace it finds, but picks good one with some randomness, next time it visit the portspace it can decide to build a port there - When all existing portspaces are know, the ship can still pick one of them to

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread toptopple
It does a job though! :) >Well, current logic was that if known portspace is found, the ship with >probability of 50% search for open sea and if found it sails this direction. >Otherwise it sail (keep on sailing) around the current land. One of the points is that this procedure is also activate