Review: Approve compile, test
Fine for me, played 30m around some savegame.
Did not do a complete codereview
--
https://code.launchpad.net/~widelands-dev/widelands/align-align/+merge/317871
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/align-align.
So now Align is HAlign and VAlign at the same time.
The originla Align is reprocuded by struct Alignment with halign and valign.
OK, we left the Era of 8bit, so no need to conserve that Memory.
Currently compiling but not in paralell to have some time for checking.
--
https://code.launchpad.net/
The proposal to merge lp:~widelands-dev/widelands/fh1-sub2div into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-sub2div/+merge/318138
--
Your team Widelands Developers is subscribed to branch
lp
Continuous integration builds have changed state:
Travis build 1983. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/204691912.
Appveyor build 1818. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fh1_sub2di
Thanks for the review :)
This means that I can finish up the next branch for the new font handler.
BTW bunnybot will now wait with the merge until Travis has passed.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-sub2div/+merge/318138
Your team Widelands Developers i
I refactored everything so that we have 1 enum class again.
There is room for a new function to vertically center text - I have added NOCOM
comments to all the instances where this could be used.
Let's see how many warnings Clang will give you now, we might do some renaming
in the enum to end u
Review: Approve compile, test, review
Works for me, lets work for Travis/Appvoyer, for completness
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-sub2div/+merge/318138
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fh1-sub2div.
___
Code looks straight forward 1,$ s/sub/div/ ;-)
will comipile this and take a look
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-sub2div/+merge/318138
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/fh1-sub2div into lp:widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/fh1-sub2div into
lp:widelands.
Commit message:
Renamed "sub" tag to "div" in new font renderer.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-sub
Continuous integration builds have changed state:
Travis build 1982. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/204562651.
Appveyor build 1817. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_align_alig
Review: Resubmit
OK found it.
I tried to play tricks with the mirror_aligment in src/graphic/richtext.cc,
but got it wrong
--
https://code.launchpad.net/~widelands-dev/widelands/align-align/+merge/317871
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/align-al
11 matches
Mail list logo
