Continuous integration builds have changed state:
Travis build 2001. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/205543441.
Appveyor build 1837. State: failed. Details:
The proposal to merge lp:~widelands-dev/widelands/table_multiselect into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/table_multiselect/+merge/312747
--
Your team Widelands Developers is subscribed
Continuous integration builds have changed state:
Travis build 1999. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/205505693.
Appveyor build 1835. State: failed. Details:
Continuous integration builds have changed state:
Travis build 1998. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/205504726.
Appveyor build 1834. State: failed. Details:
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/table_multiselect/+merge/312747
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/table_multiselect.
___
Mailing list:
Review: Needs Fixing
First of all: I like the intended change, the feature-changes as well as
separating logic and wui. Unfortunately, there are two bigger problems with
this branch.
The diff looks good to me so far. A small nit: The std::map
wanted_building_windows_ stores the coordinates as
GunChleoc has proposed merging
lp:~widelands-dev/widelands/align_cleanup_textarea into lp:widelands.
Commit message:
Removed default parameters from calls to Textarea constructor and
Table::add_column().
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
In any "Load Game Dialog" the description does not update when I use the
shift-key to extend the selection, basic functionallity is not affected however.
Shall I open a followup Bug?
--
https://code.launchpad.net/~widelands-dev/widelands/table_multiselect/+merge/312747
Your team Widelands
Review: Approve code review, compile
Couls no find any major flaw in this code,
lets get this in.
I will now test this a bit, though
--
https://code.launchpad.net/~widelands-dev/widelands/table_multiselect/+merge/312747
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/align-cleanup-box into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/align-cleanup-box/+merge/318315
--
Your team Widelands Developers is subscribed
I am pretty sure that the problem is in the table class.
Do you have time to review?
https://code.launchpad.net/~widelands-dev/widelands/table_multiselect/+merge/312747
After getting that branch in, we could do the switch from uint to int to see if
that helps with the assertion.
@bunnybot
11 matches
Mail list logo
