[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-28 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/gcc63 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 -- Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-28 Thread GunChleoc
That was an error, not a fail. @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc63. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-28 Thread GunChleoc
Thanks for these. I'll have a look if we can get rid of the failures - we might have some underlying bugs here that nobody noticed. If not, I'll remove the new assertions. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-28 Thread Notabilis
Makes sense, thanks. -- https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_buildingwindows. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-28 Thread kaputtnik
Similar crash happens in game if a building wants to be dismantled. Backtrace then: https://bugs.launchpad.net/widelands/+bug/1653460/+attachment/4828491/+files/backtrace -- https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 Your team Widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-28 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-28 Thread kaputtnik
Review: Needs Fixing Crash when accessing "About Widelands": This is Widelands Version bzr8310[bug-1653460-panel-init-width] (Debug) [...] widelands: /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243: void UI::Panel::set_size(int, int): Assertion

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlwebsite_docker into lp:widelands-website

2017-02-28 Thread kaputtnik
I got a failure on make init: django.core.exceptions.ImproperlyConfigured: settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details. make: *** [Makefile:32: init] Fehler 1 I am unsure about the benefits: > 1) get rid of

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-28 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 2012. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/206110677. -- https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 Your team Widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 2012. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/206110677. Appveyor build 1848. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-28 Thread GunChleoc
Review: Approve LGTM - let's get this in but leave the bug open, so we can have a real fix later. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc63.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-28 Thread GunChleoc
Review: Resubmit The spinbox now only layouts itself if it has size, so that should fix it. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 Your team Widelands Developers is subscribed to branch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-28 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands has been updated. Commit Message changed to: Fixed assertion failure in int UI::Panel::get_inner_h(): - Fixed bug with automatic column sizing for tables where the columns were already being

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-28 Thread GunChleoc
Duh, I confused the coords with the pos. I have removed it now. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_buildingwindows.