[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands

2017-05-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 2262. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/236985137. Appveyor build 2097. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 2260. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/236944779. Appveyor build 2095. State: failed. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands

2017-05-28 Thread GunChleoc
I have dug some more into the vision stuff and completely reimplemented the thing. The new implementation should be safe for multiplayer too. Could you please test again, and if still it doesn't work as expected, copy over some of your failing scripting code so I will have some real data to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-28 Thread Notabilis
Here, I have something more to play with for you. ;-) When I understand it right, with the current version you are always getting the log message "closing IPv6 socket" when entering the LAN lobby, right? With my newest push this message hopefully does not appear any longer. And if it works

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-28 Thread Klaus Halfmann
Review: Approve code review, compile Code looks much better, no more 4/6 duplicates. Will now play a bit, again. -- https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/net-boost-asio.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-28 Thread Notabilis
Review is dealt with. The code looks prettier now, thanks. I have to do some more reading about IPv6 and OSX. I fear we will need some platform specific code there. I will try to push something for testing in the next days. --