I have had a look at the results from the debug build, it's 10 warnings for
intended fallthroughs. We could disable the compiler flag around them, it's not
that many after all.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc7/+merge/323576
Your team Widelands Developers is requested
Review: Approve testing
I have a fresh branch and compiled from scratch.
Works again :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+merge/323721
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1687100-reveal_fields.
>The Travis failure is a compiler error that's only thrown by GCC7.
In fact, only the release build. The debug build is fine, not that I know what
the difference might be. (I honestly didn't expect any errors now since I've
built it successfully with gcc 7.x on arch)
-Wimplicit-fallthrough
Uh uh, my fault. This should have actually been an #ifdef. Is fixed now.
--
https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/net-boost-asio.
Oops, now this does not compile on OSX:
net-boost-asio/src/network/network_lan_promotion.cc:78:29: error: member
initializer
'interface_indices_v6' does not name a non-static data member or base
class
broadcast_addresses_v4(), interface_indices_v6()
in the .h files this
Review: Resubmit
Windows.h includes winsock.h, which clashes with winsock2 and boost asio.
The additional define WIN32_LEAN_AND_MEAN avoids including winsock.h and some
other headers.
--
https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364
Your team Widelands
The proposal to merge lp:~widelands-dev/widelands/remove_namespace_std into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_namespace_std/+merge/324890
--
Your team Widelands Developers is
Sounds like a plan - AppVeyor builds are broken though, so we still need to
make Windows happy.
--
https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/net-boost-asio.
P.S: we're getting a lot of warnings generated by -Wimplicit-fallthrough now,
we should check whether these are useful to us once the compiler goes through.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc7/+merge/323576
Your team Widelands Developers is requested to review the
And it's working :)
The Travis failure is a compiler error that's only thrown by GCC7.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc7/+merge/323576
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/gcc7 into lp:widelands.
Review: Approve
Yes yes yes, this was so annoying!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/remove_namespace_std/+merge/324890
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/remove_namespace_std.
I found the error in the test suite: we need to sleep after calls now, because
the playercommands are causing delays.
I deleted the commit that broke things for you from the branch's history, so
you will need to pull the branch with the option --overwrite.
--
12 matches
Mail list logo
