[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-relay into lp:widelands

2017-08-16 Thread bunnybot
Continuous integration builds have changed state: Travis build 2557. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/265326001. Appveyor build 2269. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-relay into lp:widelands

2017-08-16 Thread Notabilis
Sorry for the long silence, I should have written much earlier. My primary problem is lack of time, but when I can work on it its going well enough. I fear I won't be able to work on it in the next two weeks but hopefully I have more time afterwards. Thanks for the comments regarding the

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
In fact I have no experiences with network games and with observer so I am not sure how this modificaton copes with this... -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your team Widelands Developers is requested to review the proposed merge of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread kaputtnik
I am unsure. I think game speed can easily be adjusted by pressing PageUp/Down. So there is no need to having auto_speed in single player mode. The possibility to manually adjust the game speed applies also to the other examples you wrote (watching two ai fighting). Game speed can also be

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
Indeed, so what do you prefer? Adding it to single player or modifying help to reflect this... -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your team Widelands Developers is requested to review the proposed merge of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread kaputtnik
> "applies only in multiplayer games" is not correct, since the speed and > training mode can also be used in singleplayer games. Oh, yes, ai_trainig works in single player mode (the files get generated), but auto_speed does not work in single player games. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread GunChleoc
"applies only in multiplayer games" is not correct, since the speed and training mode can also be used in singleplayer games. @Tibor: I will have a look at fixing what I broke tomorrow when my brain is functioning again. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
--ai_trainig: Enables AI training mode, see https://wl.widelands.org/wiki/Ai%20Training/ for a full description of AI traning logic. --auto_speed: Keeps adjusting the game speed automatically, depending on FPS. Useful in conjunction with --ai_trainig. ? --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread kaputtnik
--ai_trainig: Enables creating of files used by the ai genetic algorythm to get a stronger ai. If you want to train the ai see https://wl.widelands.org/wiki/Ai%20Training/ for a full description. Applies only in mutliplayer games. --auto_speed: Keeps adjusting the game speed automatically,

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
Yes, I noticed these two lines. I dont know what is wrong and how to suppress them... But I dont agree with other two comments --auto_speed can be useful also for peoples who just want to watch AI fighting each other without any intentions about training... We split the single command line

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread kaputtnik
Some observations: Start of widelands: There are two lines in terminal saying: > [] Section [global], key 'ai_training' not used (did you spell the name > correctly?) > [] Section [global], key 'auto_speed' not used (did you spell the name > correctly?) Command line options: --auto_speed:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_mac into lp:widelands

2017-08-16 Thread bunnybot
Continuous integration builds have changed state: Travis build 2550. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/265048443. Appveyor build 2373. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
OK, added the required comment. Not in data wai files yet, but you can see it in generated wai files. Eventually with promotion of trained AI, the comment will get also in source wai files. I did not bother with it now. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-relay into lp:widelands

2017-08-16 Thread SirVer
Notabilis, could you give us an update on your work? I am quite curious. Are you blocked in any way? -- https://code.launchpad.net/~widelands-dev/widelands/net-relay/+merge/327491 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-relay

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1664052-expedition-shipwindow-crash into lp:widelands

2017-08-16 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1664052-expedition-shipwindow-crash into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1664052-expedition-shipwindow-crash/+merge/318986 --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables into lp:widelands

2017-08-16 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables into lp:widelands has been updated. Status: Needs review => Merged For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables into lp:widelands

2017-08-16 Thread SirVer
Review: Approve lgtm. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables/+merge/326256 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
I will investigate the possibility of such comment in wai files... So latest version is functional or should I revert to 8404 + preserve you changes for help texts -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your team Widelands Developers is requested

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread GunChleoc
Great, I have done some proofreading :) I don't expect to gat around to cleaning up what I broke today, so go ahead and take over the branch again if you want. It would still be good to have a link to https://wl.widelands.org/wiki/Ai%20Training/ in the wai files. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread GunChleoc
No, that's the usual error that we always get on GCC and that I haven't managed to get rid of yet. I think I broke the speed thing myself when I got rid of the extra dynamic_cast during code review. -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/toggle_immovables into lp:widelands

2017-08-16 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/toggle_immovables into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/toggle_immovables/+merge/328977 -- Your team Widelands Developers is subscribed

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
This is not related I think... -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_training_switch into lp:widelands.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread Klaus Halfmann
I get some compiler warning here: [2550/2827] Building CXX object src/scripting/CMakeFiles/scripting_logic.dir/persistence.cc.o In file included from ../src/scripting/eris.h:25:0, from ../src/scripting/persistence.cc:27: ../src/third_party/eris/eris.h:150:38: warning: redundant

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread TiborB
@Gun - but I tested it yesterday... and should be no difference if DEBUG or RELEASE -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_training_switch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_mac into lp:widelands

2017-08-16 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/compiler_warnings_mac into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_mac/+merge/329090 Let's see if this will

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread Klaus Halfmann
When wil appvoyer kick in? I would like to fetch the binary form there. OTOH Ill be on tour for some days now. -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your team Widelands Developers is requested to review the proposed merge of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_training_switch into lp:widelands

2017-08-16 Thread GunChleoc
The autospeed doesn't seem to be working any more - I had switched to a release build though. -- https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008 Your team Widelands Developers is requested to review the proposed merge of