Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1727673 into lp:widelands

2017-10-28 Thread TiborB
This is exactly the same situation as when port constructionsite disappears during unloading of wares/worker. So yes.. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1727673/+merge/332945 Your team Widelands Developers is requested to review the proposed merge of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread TiborB
Review: Approve Ok for me as well. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1075562-initial-trainers. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-28 Thread kaputtnik
Forgotton: I have modified the image used for the dropdown in the navigation(just made it smaller in height). In the detailed search page the last "Search in" option (News) is cut at the right side in some browsers. Don't know why or how to fix this. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-28 Thread kaputtnik
I managed to get the virtual environment under windows working... I have tested the changes with Chrome (win7, win10) and IE11(win7). It should work now. Please test again. I you want to you could also test the latest changes regarding spam. Just write 5 posts/topics with a keyword (e.g.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-appveyor-libicu into lp:widelands

2017-10-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 2718. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/294102536. Appveyor build 2531. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-appveyor-libicu into lp:widelands

2017-10-28 Thread Notabilis
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-appveyor-libicu into lp:widelands. Commit message: Fixing windows build by requiring newer version of libicu. Requested reviews: Widelands Developers (widelands-dev) For more details, see:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread Notabilis
The proposal to merge lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands has been updated. Commit Message changed to: Adding initial trainers to starting conditions. For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread Notabilis
I added four trainers to the Trading Outpost condition. In this condition there are quite some additional workers available anyway, so why not also a trainer more than normal. The artifacts-error also happens with succeeding builds. The reason for the failure might be the missing

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread Klaus Halfmann
Review: Approve review, compile, test Appveyor faled with > No artifacts found matching > 'Widelands-_widelands_dev_widelands_bug_1075562_initial_trainers-2530-Debug-x86.exe' > path No idea why this happens? But all 4 variants are OK Ichecekd the code and even started every variant. Fine foe

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread bunnybot
Continuous integration builds have changed state: Travis build 2717. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/294033839. Appveyor build 2530. State: failed. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-28 Thread GunChleoc
That is why developing stuff with JavaScript is sometimes no fun at all :( -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/nethost-split into lp:widelands

2017-10-28 Thread GunChleoc
@bunnybot merge I hope to have time next week to look at your bigger changes. -- https://code.launchpad.net/~widelands-dev/widelands/nethost-split/+merge/332385 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/nethost-split.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1727673 into lp:widelands

2017-10-28 Thread GunChleoc
Code LGTM, not tested. What happens to the builder on the ship, will he be transported back and unloaded at a warehouse? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1727673/+merge/332945 Your team Widelands Developers is requested to review the proposed merge of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread kaputtnik
Klaus, since only some data in the datafolder was changed there is no need to compile this branch :) Just use the option --datadir= -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is requested to review the proposed

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-10-28 Thread GunChleoc
Review: Resubmit This should be ready now. I left the data container in Python as it is with the total for each locale, because the entires come in per directory rather than per locale. So, I sacrificed some memory in favour of code readability + performance. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread Klaus Halfmann
Code looks straight foreward, will compile and play this now - as training for the tournament. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is requested to review the proposed merge of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread GunChleoc
I agree - we could even throw in a 4th trainer for the Trading Outpost, since it's the Beginner's or "help the AI" setting. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is requested to review the proposed merge

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread kaputtnik
I had never played other than Headquarters starting condition, but would say that 'Trading Outpost' should have the same settings. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is requested to review the proposed

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread Notabilis
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands. Commit message: Adding initial trainers to Headquarters and Fortified Village starting conditions. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1075562