Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_buildinglimit_savegames into lp:widelands

2017-11-12 Thread Klaus Halfmann
Tried to open some training game from trunk, gave me: ai_buildinglimit_savegames klaus$ Game: Reading ai persistent data ... Assertion failed: (player->ai_data.remaining_buildings_size == player->ai_data.remaining_basic_buildings.size()), function read, file /Users/klaus/develop/widelands-repo/a

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_buildinglimit_savegames into lp:widelands

2017-11-12 Thread TiborB
Review: Approve I am not glad about this change, but I was too pondering if the asserts are not too strong here. But if it is needed, I agree with this -- https://code.launchpad.net/~widelands-dev/widelands/ai_buildinglimit_savegames/+merge/333592 Your team Widelands Developers is subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_buildinglimit_savegames into lp:widelands

2017-11-12 Thread Klaus Halfmann
M,, I tried to remove the asserts, too. But this still failed me. Will try your changes now. -- https://code.launchpad.net/~widelands-dev/widelands/ai_buildinglimit_savegames/+merge/333592 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_buildinglimit_savegame

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/check_representative_image into lp:widelands

2017-11-12 Thread Klaus Halfmann
Review: Approve review, compile, test Broke this on puropse and tried to play the economy tutorial: There's no configuration file, using default values. ┏━ Running Lua for world: ┃Resources: 50ms ┃Terrains: 69ms ERROR: Unused key "attributes" in LuaTable. Please report as a bug. ERROR: Un

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_buildinglimit_savegames into lp:widelands

2017-11-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 2799. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/301021330. Appveyor build 2610. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_building

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_buildinglimit_savegames into lp:widelands

2017-11-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/ai_buildinglimit_savegames into lp:widelands. Commit message: Removed cnt_limit_by_aimode asserts from AI code because they're breaking savegame compatibility. Requested reviews: TiborB (tiborb95) For more details, see: https://code.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/map_version_gt_19 into lp:widelands-website

2017-11-12 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/map_version_gt_19 into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1731732 in Widelands Website: "Check whether a map needs a version of Widelands newer than Build 18" ht

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

2017-11-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/clang-tidy-round1/+merge/333560 -- Your team Widelands Developers is subscribed t

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

2017-11-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 2796. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/300877100. Appveyor build 2607. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_clang_tidy_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

2017-11-12 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/clang-tidy-round1/+merge/333560 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/clang-tidy-round1. ___ Mailing list: https://launchpad.net/~widela

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

2017-11-12 Thread bunnybot
Error merging this proposal: Output: stdout: stderr: M src/ai/defaultai.cc M src/economy/expedition_bootstrap.cc M src/economy/flag.cc M src/economy/portdock.cc M src/economy/test/test_routing.cc M src/editor/editorinteractive.cc M src/game_io/game_interactive_player_packet.cc M s