This is how pointers work in a nutshell:
datatype* foo points to an address in memory. It also takes ownership of that
piece of memory.
dataype& foo is the reference (what the pointer refers to), think of it as the
actual data in memory.
Let's have a look at the function:
std::unique_ptr L
The proposal to merge lp:~widelands-dev/widelands/bug-1734199 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1734199/+merge/334369
--
Your team Widelands Developers is subscribed to branch
lp
The proposal to merge lp:~widelands-dev/widelands/bug-1734046-statistics_menu
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1734046-statistics_menu/+merge/334398
--
Your team Widelands Develo
After a game has been started, using the indexes is good, because it's more
efficient. During game startup, those indexes are automatically generated from
names. Configuration looks like this:
tribes:new_militarysite_type {
name = "atlanteans_guardhall",
descname = pgettext("at
MacOX can't install sphinx
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1734046-statistics_menu/+merge/334398
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1734046-statistics_menu.
_
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 2887. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308874869.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1734046-statistics_menu/+merge/334398
Yo
Continuous integration builds have changed state:
Travis build 2887. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308874869.
Appveyor build 2696. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_173404
Continuous integration builds have changed state:
Travis build 2886. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308873993.
Appveyor build 2695. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_173474
Review: Approve testing
approve testing :-)
Thanks Jukka!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1734748-savegame-filename/+merge/334429
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1734748-savegame-filename.
___
The proposal to merge lp:~widelands-dev/widelands/add_player_to_note_economy
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/add_player_to_note_economy/+merge/334371
--
Your team Widelands Develope
1) Thanks, looks good. Not that I really understand this construct.
2) Okay. Seems to be worth looking into that, but not in this branch.
3) I added a simple protocol for this. Please see relay_protocol.h (diff line
1918ff) for the design, it should us allow what we want to do. Metaserver
suppo
> but you could run a backup once on the live system just to see how long it
> takes
I remember the last time i did this it was not clear to me how long it takes.
Say if the terminal lost the ssh connection it stays in a frozen way (no
response from the server). That time it takes incredible lo
@bunnybot merge force
still mac os x woes.
--
https://code.launchpad.net/~widelands-dev/widelands/add_player_to_note_economy/+merge/334371
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/add_player_to_note_economy.
_
Continuous integration builds have changed state:
Travis build 2885. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308851663.
Appveyor build 2694. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_add_player
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 2885. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308851663.
--
https://code.launchpad.net/~widelands-dev/widelands/add_player_to_note_economy/+merge/334371
You
The proposal to merge
lp:~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle/+merge/334428
--
You
Yes, setting it to maintance is surely saver - but you could run a backup once
on the live system just to see how long it takes and if it is feasible to set
the site to maintance for this.
--
https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam_app/+merge/334232
Your team Widela
Mac OS X not running for unrelated reasons.
@bunnybot merge force
> is this reasonable?
I am actually not sure. So I left it out.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle/+merge/334428
Your team Widelands Developers is subscribed to branch
l
Hmm, we need some Barbarin to this brew Problem ;-)
>From Travis using XCode 8.3
/usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `':
Homebrew must be run under Ruby 2.3! You're running 2.0.0. (RuntimeError)
Brewers to the brew kettle, please?
--
https://code.launchpad.net/~widelands-dev/wide
Thanks for all the cleanup you did!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1734046-statistics_menu/+merge/334398
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1734046-statistics_menu.
___
Mai
Please enlighten with the magic of the std::unique_ptr<>.
What was the Problem and how does this change fix it?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1734748-savegame-filename/+merge/334429
Your team Widelands Developers is requested to review the proposed merge of
lp:~wid
Review: Approve review
Yep, this is basically my fix, will not compile or test this one, though.
See
http://bazaar.launchpad.net/~widelands-dev/widelands/bug_1730204-crash/revision/8496
I added this code as well:
void BuildingWindow::die() {
assert(!is_dying_); // Building Window must not
Mhh ravis has only this, unrelated Problem:
WARNING: The following packages cannot be authenticated!
gcc-7-base libgcc1 libstdc++6 libasan4 libatomic1 libcc1-0 libcilkrts5
libgomp1 libisl15 libitm1 liblsan0 libmpfr4 libmpx2 libquadmath0 libtsan0
libubsan0 cpp-7 libgcc-7-dev gcc-7 libstdc++-
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 2884. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308851086.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle/+merg
Continuous integration builds have changed state:
Travis build 2884. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308851086.
Appveyor build 2693. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_invali
After reading your post and rethinking my suggestion it is much problematic as
it seems. Beside the forums, there are also other things which write to the
database while using the website, e.g. Downloading a map (Increasing the
download number).
It is also not clear how to handle active session
I think that's a good idea - maybe still switch the forums off though, since
navigating them also needs changes to the database.
--
https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam_app/+merge/334232
Your team Widelands Developers is subscribed to branch lp:widelands-website.
Well, in this case, it seems like I can't, except for the one in the
interactive base - I'll get a heap-use-after-free because boost:signals2 will
barf on it - it just doesn't like it when the window containing the button is
gone, just like with the original bug.
Lambdas are nice though, they a
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle/+merge/334428
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle.
___
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1734748-savegame-filename into lp:widelands.
Commit message:
Fixed pointer corruption with filename when saving a game twice (Patch by Jukka
Pakarinen (flegu)).
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
SirVer has proposed merging
lp:~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle into
lp:widelands.
Commit message:
Check if our window is dying before investigating a building note.
Patch by Klaus Halfmann.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
31 matches
Mail list logo
