Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-23 Thread kaputtnik
Ah forgotten: Not directly related to this branch but a question about the translation makro '_' and the use of brackets for strings instead of double quotation marks: Does the _ only work with '_[[some text]]' and not with _"some text"? The doc for _ (https://wl.widelands.org/docs/wl/autogen_g

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-23 Thread kaputtnik
Changed the code example and the resulting image. I have tried also to explain in short what the '..' are used for. While a first reader may does not know what my explanation means exactly, one can search the web for the keyword. Feel free to rephrase :-) -- https://code.launchpad.net/~wideland

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-02-23 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/string-fixes into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/337849 -- Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page into lp:widelands-website

2018-02-23 Thread GunChleoc
Review: Approve LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands-website/bug-1750102_map_admin_page/+merge/338767 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-23 Thread GunChleoc
Thanks! Maybe it would indeed be best if you created the examples - I am too close to this, so you know better what is needed here. -- https://code.launchpad.net/~widelands-dev/widelands/fh1-documentation/+merge/337545 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wid

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-02-23 Thread GunChleoc
Thanks for the review :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/337849 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/string-fixes. ___ Mailing list: https://launc

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-02-23 Thread bunnybot
Continuous integration builds have changed state: Travis build 3228. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/345141547. Appveyor build 3037. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_string_fixe

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page into lp:widelands-website

2018-02-23 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1750102 in Widelands Website: "Allow map editing without world name" https://bugs.launchpad.ne

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-02-23 Thread hessenfarmer
Review: Approve LGTM Thanks for doing the empire 4 string. -- https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/337849 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/string-fixes. ___ Mailing

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-23 Thread kaputtnik
I think this is better :-) Maybe i have not explained enough about the code example for the attributes. The reason why i am so stubborn for a related code example is that it took me some time to fiddle out how to use them. E.g. it was unclear how to use values for an attribute. I would suggest

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisians into lp:widelands

2018-02-23 Thread GunChleoc
I'm on the wrong computer right now, so some string fixes as diff comments in-line. I'd still like to look at the Lua code and the scenario texts. Scenario texts can be done later though, because I can control when I add them to Transifex. The introductions need to be ready though. At first gl

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1750561 into lp:widelands

2018-02-23 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1750561 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1750561/+merge/338352 -- Your team Widelands Developers is subscribed to branch lp